From 03648bbfdeccb4d0454758f2e930542e11eb1f5e Mon Sep 17 00:00:00 2001 From: Jason Maynard Date: Fri, 13 Dec 2019 15:11:31 -0800 Subject: [PATCH] Add calls in unit tests to cover logging and jsonify of video object. --- analytics/config/config_test.go | 5 +++++ analytics/filesystem/file_module_test.go | 10 ++++++++++ 2 files changed, 15 insertions(+) diff --git a/analytics/config/config_test.go b/analytics/config/config_test.go index ba2524e82d7..0fd3ec2019e 100644 --- a/analytics/config/config_test.go +++ b/analytics/config/config_test.go @@ -45,6 +45,11 @@ func TestSampleModule(t *testing.T) { if count != 4 { t.Errorf("PBSAnalyticsModule failed at LogAmpObject") } + + am.LogVideoObject(&analytics.VideoObject{}) + if count != 5 { + t.Errorf("PBSAnalyticsModule failed at LogVideoObject") + } } type sampleModule struct { diff --git a/analytics/filesystem/file_module_test.go b/analytics/filesystem/file_module_test.go index 4ec2bb6abaa..6e2d9f6263b 100644 --- a/analytics/filesystem/file_module_test.go +++ b/analytics/filesystem/file_module_test.go @@ -34,6 +34,15 @@ func TestAuctionObject_ToJson(t *testing.T) { } } +func TestVideoObject_ToJson(t *testing.T) { + vo := &analytics.VideoObject{ + Status: http.StatusOK, + } + if voJson := jsonifyVideoObject(vo); strings.Contains(voJson, "Transactional Logs Error") { + t.Fatalf("AuctionObject failed to convert to json") + } +} + func TestSetUIDObject_ToJson(t *testing.T) { so := &analytics.SetUIDObject{ Status: http.StatusOK, @@ -64,6 +73,7 @@ func TestFileLogger_LogObjects(t *testing.T) { defer os.RemoveAll(TEST_DIR) if fl, err := NewFileLogger(TEST_DIR + "//test"); err == nil { fl.LogAuctionObject(&analytics.AuctionObject{}) + fl.LogVideoObject(&analytics.VideoObject{}) fl.LogAmpObject(&analytics.AmpObject{}) fl.LogSetUIDObject(&analytics.SetUIDObject{}) fl.LogCookieSyncObject(&analytics.CookieSyncObject{})