-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforcing Valid Accounts #1013
Comments
Adding a blacklist option may make for a smoother transition. Be able to remove bad actors while giving time for good actors to establish a formal relationship. |
@hhhjort - my understanding is that there's already a 'blacklist' option -- #1014 Based on the committee discussion last week, 'valid' and 'invalid' account features are both useful options. The 'invalid' account list is a way for a PBS host company to reject only requests from particular accounts, but they may not otherwise mind unknown accounts. The 'valid' list is a more proactive way to control traffic impact, but not every request contains the account, e.g. AMP. Will open a separate discussion on alternate ways to obtain the account ID. In the meantime, we plan to implement this for PBS-Java in the next sprint or two. |
This is done in PBS-Java. Assigning to @hhhjort for PBS-Go implementation. |
As @laurb9 mentioned, we recently added additional account configuration options to PBS-Go. Hosts can now specify account-specific configuration via account-specific json config files. Also, we have the following global account configuration options:
Between the global and account-specific options, the host now has more control. If the host wants to require requests contain a valid account id, they need to set global option If the host wants to default to allowing all accounts but block specific accounts, they need to:
If the host wants to default to disabling all accounts and only allow particular accounts, they need to:
|
We need to have better control over who's hitting our Prebid Server cluster, so want to have a flag which tells PBS to reject (HTTP 401) any unrecognized account.
Account ID comes from
site.publisher.id
orapp.publisher.id
in the request, which is compared to values in the accounts tableThe proposed config is a new flag in the
settings
section:The original 'legacy' protocol used to reject unknown accounts based on the 'accounts' table lookup, but the OpenRTB interface doesn't enforce accounts. So this is really re-implementing a feature we used to have.
The text was updated successfully, but these errors were encountered: