tests ignore expected message field. When not ignored, tests actually fail. Currently tests pass when they should not.

[draksler]

tests in TestBadRequests in auction_test.go (and a few others) are ignoring the expected message field due to the gr.description != "" condition.
If the condition is removed, and the messages are actually validated, the tests fail.

[SyntaxNode]

Nice find. I'm looking into this. I don't know why a condition like gr.description != "" exists at all.

[SyntaxNode]

We're working to fix this. Looks like there are two tests which aren't running and should. The other failures with removing that condition are due to unclear setup. This was probably our first pass at json based tests.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[SyntaxNode]

The test setup in that package is a mix of json and code configuration. It's really difficult to follow. @guscarreon has rewritten them in a much cleaner style with all setup expressed in the json files, as we do for other parts of the code. I'll close this ticket when #1450 is merged.

[SyntaxNode]

The test setup in that package is a mix of json and code configuration. It's really difficult to follow. @guscarreon has rewritten them in a much cleaner style with all setup expressed in the json files, as we do for other parts of the code. I'll close this ticket when #1450 is merged.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[SyntaxNode]

auction_test.go has been completely refactored to resolve this issue.