Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SomoAudience bid adapter #2152

Closed
bretg opened this issue Feb 4, 2022 · 3 comments
Closed

Remove SomoAudience bid adapter #2152

bretg opened this issue Feb 4, 2022 · 3 comments

Comments

@bretg
Copy link
Contributor

bretg commented Feb 4, 2022

SomoAudience no longer supports their server-side adapter, so would like to drop it. Email below.

We discussed in PBS committee and agreed that the best way to remove an adapter is:

  • make sure there's a way to put the biddercode on a "soft-error" list so publishers don't start getting 400 errors from Prebid Server if they're utilizing the code in their AdUnits
  • then remove the adapter code from the repo
---------- Forwarded message ---------
From: Todd H
Date: Wed, Jan 26, 2022 at 11:34 AM
Subject: Re: SomoAudience Prebid Server adapter floors issue
To: Bret G
Cc: Todd H


Hi Bret.,

We will not be maintaining the Somo Prebid adapter.  Let me know what steps I need to take to remove the Somo from prebid.  

TY,

Todd
@SyntaxNode
Copy link
Contributor

@bretg Will Somo open a PR themselves to remove their adapter? That would be preferred. The "soft-error" list already exists in PBS-Go, Please see

func GetDisabledBiddersErrorMessages(infos config.BidderInfos) map[string]string {
. A removed adapter is considered a disabled adapter with a custom error message indicating its removal from PBS. At some point in the future when enough time has passed we may decide to clean up these entries.

@bretg
Copy link
Contributor Author

bretg commented Feb 10, 2022

I doubt we'll get a PR from SomoAudience. I updated the docs side to get them off that list.

@bretg
Copy link
Contributor Author

bretg commented Feb 28, 2022

Done with PBS-Java 1.84

@bretg bretg closed this as completed Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants