Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cache ttl for audio and native #2980

Closed
bretg opened this issue Jul 27, 2023 · 5 comments
Closed

Support cache ttl for audio and native #2980

bretg opened this issue Jul 27, 2023 · 5 comments
Labels

Comments

@bretg
Copy link
Contributor

bretg commented Jul 27, 2023

PBS supports different cache lengths for mediatypes banner and video. Should we consider splitting this out to support native and audio?

In considering this for issue #2975, I realized that our cache length ought to be capped by the bidder's ORTB exp parameter. Perhaps we're already doing this?

@bretg
Copy link
Contributor Author

bretg commented Jul 28, 2023

Discussed in backlog meeting:

  • agreed that extending cache length controls to native and audio makes sense. Just mediatypes, though, and DOOH is not a mediatype.
  • Agreed that cache length should be capped by any exp parameter. Go and Java teams to look into whether this is already the case.

@bretg bretg moved this from Triage to Needs Requirements in Prebid Server Prioritization Jul 28, 2023
@SyntaxNode
Copy link
Contributor

PBS-Go already allows default cache values to be defined for all media types (banner, video, audio, native) and the exp field is already taken into consideration during cache length calculation.

@bretg
Copy link
Contributor Author

bretg commented Sep 13, 2023

Discussed in committee

  • Agreed on account level config: cache-ttl.{banner,video,audio,native}
  • Hardcoded defaults should be
    • banner: 300
    • video: 1500
    • native: 300
    • audio: 1500

PBS-Java uses different config for banner/video that will be deprecated.

@bretg bretg moved this from Needs Requirements to Ready for Dev in Prebid Server Prioritization Sep 13, 2023
@bretg bretg changed the title Cache revisited: mediatype and ORTB exp Support cache ttl for audio and native Sep 26, 2023
@bretg
Copy link
Contributor Author

bretg commented Nov 30, 2023

Working with the Java team, this is the order of how the cache length is determined:

  1. bid.exp
  2. corresponding imp.exp
  3. ext.prebid.cache.{bids/vastxml}.ttlseconds
  4. account.auction.{banner/video}-cache-ttl - deprecated. To be removed in a future major release.
  5. cache.{banner/video}-ttl-seconds - deprecated. To be removed in a future major release.

To these, PBS-Java will add the config that PBS-Go has at

v.SetDefault("cache.default_ttl_seconds.banner", 0)

  1. cache.default_ttl_seconds.{banner,video,native,audio}

@bretg
Copy link
Contributor Author

bretg commented Dec 11, 2024

released with PBS-Java 3.16

@bretg bretg closed this as completed Dec 11, 2024
@github-project-automation github-project-automation bot moved this from Ready for Dev to Done in Prebid Server Prioritization Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants