Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid.Meta not being fully returned #3101

Closed
ccorbo opened this issue Sep 13, 2023 · 1 comment
Closed

Prebid.Meta not being fully returned #3101

ccorbo opened this issue Sep 13, 2023 · 1 comment
Assignees
Labels

Comments

@ccorbo
Copy link
Contributor

ccorbo commented Sep 13, 2023

When testing out passing through rendererUrl as part of seatbid[].bid[].ext.prebid.meta.rendererUrl, which was completed in #3087. I noticed that everything in prebid.meta was being dropped outside of adaptercode.

For example I have a mock response set up with the following seatbid[].bid[].ext:
image

For the response, rendererUrl is dropped and only adaptercode is returned in ext.prebid.meta.
Example bid[].ext response:
image

This looks to be because the adapter code is being created / set in prebid.meta before the bid ext is being created. So it never enters this block https://github.com/prebid/prebid-server/blob/master/exchange/exchange.go#L1306

I created a Draft PR with an example of a fix. I would like confirmation that this is actually an issue, and that this approach is appropriate before I go updating all the tests. Want to make sure I'm not missing something obvious.
PR: #3100

Example bid[].ext response with changes in PR running locally:
image

@bretg
Copy link
Contributor

bretg commented Nov 3, 2023

Closing this issue as resolved with PR: #3100

@bretg bretg closed this as completed Nov 3, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Prebid Server Prioritization Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants