You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When testing out passing through rendererUrl as part of seatbid[].bid[].ext.prebid.meta.rendererUrl, which was completed in #3087. I noticed that everything in prebid.meta was being dropped outside of adaptercode.
For example I have a mock response set up with the following seatbid[].bid[].ext:
For the response, rendererUrl is dropped and only adaptercode is returned in ext.prebid.meta.
Example bid[].ext response:
I created a Draft PR with an example of a fix. I would like confirmation that this is actually an issue, and that this approach is appropriate before I go updating all the tests. Want to make sure I'm not missing something obvious.
PR: #3100
Example bid[].ext response with changes in PR running locally:
The text was updated successfully, but these errors were encountered:
When testing out passing through rendererUrl as part of
seatbid[].bid[].ext.prebid.meta.rendererUrl
, which was completed in #3087. I noticed that everything in prebid.meta was being dropped outside of adaptercode.For example I have a mock response set up with the following seatbid[].bid[].ext:
![image](https://private-user-images.githubusercontent.com/19716777/267777502-b0af57a1-c0d1-4feb-a4e1-5d6a547c9664.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzQ0NTkzMTQsIm5iZiI6MTczNDQ1OTAxNCwicGF0aCI6Ii8xOTcxNjc3Ny8yNjc3Nzc1MDItYjBhZjU3YTEtYzBkMS00ZmViLWE0ZTEtNWQ2YTU0N2M5NjY0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEyMTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMjE3VDE4MTAxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUwMThiYjI4ODBjMmYwMGEzMDYzMTc0MGMyYzY0ODBlMTAxNDk3MDA0NDA3YjJjNzJkNmM1MzA0NmQ1ZjUwM2EmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.LD768LNPTnyRtdvgAywCzFalEaMuV5dAXmMva3973MI)
For the response, rendererUrl is dropped and only adaptercode is returned in ext.prebid.meta.
![image](https://private-user-images.githubusercontent.com/19716777/267777877-7eef8019-21d1-4b00-a97f-a92244cd02f3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzQ0NTkzMTQsIm5iZiI6MTczNDQ1OTAxNCwicGF0aCI6Ii8xOTcxNjc3Ny8yNjc3Nzc4NzctN2VlZjgwMTktMjFkMS00YjAwLWE5N2YtYTkyMjQ0Y2QwMmYzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEyMTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMjE3VDE4MTAxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBlNGRhN2VjYmEwNzljMWU3ZDk0MjJiNDM2ZWU1MjVlYjc2NmYwYTcwZDYwYzJiMzFiZmY4YjBhMTUyYjRhNGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.9SviRSnvxGfnhAXQCc3JsTYmMiE8BlorCEkUq3zylSo)
Example bid[].ext response:
This looks to be because the adapter code is being created / set in prebid.meta before the bid ext is being created. So it never enters this block https://github.com/prebid/prebid-server/blob/master/exchange/exchange.go#L1306
I created a Draft PR with an example of a fix. I would like confirmation that this is actually an issue, and that this approach is appropriate before I go updating all the tests. Want to make sure I'm not missing something obvious.
PR: #3100
Example bid[].ext response with changes in PR running locally:
![image](https://private-user-images.githubusercontent.com/19716777/267778657-ff818f62-2e68-4a1a-b357-39af7f599287.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzQ0NTkzMTQsIm5iZiI6MTczNDQ1OTAxNCwicGF0aCI6Ii8xOTcxNjc3Ny8yNjc3Nzg2NTctZmY4MThmNjItMmU2OC00YTFhLWIzNTctMzlhZjdmNTk5Mjg3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEyMTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMjE3VDE4MTAxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdmNzllNzMyYjUyNzA3ZmZjMDZhNzRiY2FmNTdjMWRlMzJjZjEwZTc4N2UzOGY5MjViMTM0ODY2YTFiMDk4YzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.qCaHUd7khvWsS9M4hbGxUM-TgdW0xXwhXCzhYZ5rX5g)
The text was updated successfully, but these errors were encountered: