From 245a8fb09c31287f8924520df93ce4691005976a Mon Sep 17 00:00:00 2001 From: smithaa Date: Fri, 9 Nov 2018 14:47:57 -0800 Subject: [PATCH 1/3] Brightroll auction type explicitly default to first price auction --- adapters/brightroll/brightroll.go | 1 + .../exemplary/banner-native-audio.json | 154 +++++++++++++++++ .../exemplary/banner-video-native.json | 156 ++++++++++++++++++ .../exemplary/banner-video.json | 1 + .../exemplary/simple-banner.json | 1 + .../exemplary/simple-video.json | 1 + .../exemplary/valid-extension.json | 1 + .../exemplary/video-and-audio.json | 110 ++++++++++++ .../exemplary/simple-banner.json | 1 + 9 files changed, 426 insertions(+) create mode 100644 adapters/brightroll/brightrolltest/exemplary/banner-native-audio.json create mode 100644 adapters/brightroll/brightrolltest/exemplary/banner-video-native.json create mode 100644 adapters/brightroll/brightrolltest/exemplary/video-and-audio.json diff --git a/adapters/brightroll/brightroll.go b/adapters/brightroll/brightroll.go index 0d218ef5fa6..65758ac1a77 100644 --- a/adapters/brightroll/brightroll.go +++ b/adapters/brightroll/brightroll.go @@ -52,6 +52,7 @@ func (a *BrightrollAdapter) MakeRequests(request *openrtb.BidRequest) ([]*adapte return nil, errs } + request.AT = 1 //Defaulting to first price auction for all prebid requests reqJSON, err := json.Marshal(request) if err != nil { errs = append(errs, err) diff --git a/adapters/brightroll/brightrolltest/exemplary/banner-native-audio.json b/adapters/brightroll/brightrolltest/exemplary/banner-native-audio.json new file mode 100644 index 00000000000..0c4749761dc --- /dev/null +++ b/adapters/brightroll/brightrolltest/exemplary/banner-native-audio.json @@ -0,0 +1,154 @@ +{ + "mockBidRequest": { + "id": "test-request-id", + "imp": [ + { + "id": "test-imp-id", + "banner": { + "format": [ + { + "w": 300, + "h": 250 + }, + { + "w": 300, + "h": 600 + } + ] + }, + "ext": { + "bidder": { + "publisher": "cafemom" + } + } + }, + { + "id": "unsupported-native-imp", + "native": { + "ver": "1.1", + "request": "{\"ver\":\"1.1\",\"context\":1,\"contextsubtype\":11,\"assets\":[{\"id\":1,\"required\":1,\"title\":{\"len\":500}},{\"id\":2,\"required\":1,\"img\":{\"type\":3,\"wmin\":1,\"hmin\":1}},{\"id\":3,\"required\":0,\"data\":{\"type\":1,\"len\":200}},{\"id\":4,\"required\":0,\"data\":{\"type\":2,\"len\":15000}},{\"id\":5,\"required\":0,\"data\":{\"type\":6,\"len\":40}},{\"id\":6,\"required\":0,\"data\":{\"type\":500}}]}" + }, + "ext": { + "bidder": { + "publisher": "cafemom" + } + } + }, + { + "id": "unsupported-audio-imp", + "audio": { + "mimes": [ + "video/mp4" + ] + }, + "ext": { + "bidder": { + "publisher": "cafemom" + } + } + } + ] + }, + "httpCalls": [ + { + "expectedRequest": { + "uri": "http://east-bid.ybp.yahoo.com/bid/appnexuspbs?publisher=cafemom", + "body": { + "id": "test-request-id", + "at":1, + "imp": [ + { + "id": "test-imp-id", + "banner": { + "format": [ + { + "w": 300, + "h": 250 + }, + { + "w": 300, + "h": 600 + } + ] + }, + "ext": { + "bidder": { + "publisher": "cafemom" + } + } + }, + { + "id": "unsupported-native-imp", + "native": { + "ver": "1.1", + "request": "{\"ver\":\"1.1\",\"context\":1,\"contextsubtype\":11,\"assets\":[{\"id\":1,\"required\":1,\"title\":{\"len\":500}},{\"id\":2,\"required\":1,\"img\":{\"type\":3,\"wmin\":1,\"hmin\":1}},{\"id\":3,\"required\":0,\"data\":{\"type\":1,\"len\":200}},{\"id\":4,\"required\":0,\"data\":{\"type\":2,\"len\":15000}},{\"id\":5,\"required\":0,\"data\":{\"type\":6,\"len\":40}},{\"id\":6,\"required\":0,\"data\":{\"type\":500}}]}" + }, + "ext": { + "bidder": { + "publisher": "cafemom" + } + } + }, + { + "id": "unsupported-audio-imp", + "audio": { + "mimes": [ + "video/mp4" + ] + }, + "ext": { + "bidder": { + "publisher": "cafemom" + } + } + } + ] + } + }, + "mockResponse": { + "status": 200, + "body": { + "id": "test-request-id", + "seatbid": [ + { + "seat": "958", + "bid": [{ + "id": "7706636740145184841", + "impid": "test-imp-id", + "price": 0.500000, + "adid": "29681110", + "adm": "some-test-ad", + "adomain": ["yahoo.com"], + "cid": "958", + "crid": "29681110", + "h": 250, + "w": 300 + }] + } + ], + "bidid": "5778926625248726496", + "cur": "USD" + } + } + } + ], + + "expectedBids": [ + { + "bid": { + "id": "7706636740145184841", + "impid": "test-imp-id", + "price": 0.5, + "adm": "some-test-ad", + "adid": "29681110", + "adomain": ["yahoo.com"], + "cid": "958", + "crid": "29681110", + "w": 300, + "h": 250 + }, + "type": "banner" + } + ] + +} diff --git a/adapters/brightroll/brightrolltest/exemplary/banner-video-native.json b/adapters/brightroll/brightrolltest/exemplary/banner-video-native.json new file mode 100644 index 00000000000..6622887fb93 --- /dev/null +++ b/adapters/brightroll/brightrolltest/exemplary/banner-video-native.json @@ -0,0 +1,156 @@ +{ + "mockBidRequest": { + "id": "test-request-id", + "imp": [ + { + "id": "test-imp-id", + "banner": { + "format": [ + { + "w": 300, + "h": 250 + }, + { + "w": 300, + "h": 600 + } + ] + }, + "ext": { + "bidder": { + "publisher": "cafemom" + } + } + }, + { + "id": "unsupported-native-imp", + "native": { + "ver": "1.1", + "request": "{\"ver\":\"1.1\",\"context\":1,\"contextsubtype\":11,\"assets\":[{\"id\":1,\"required\":1,\"title\":{\"len\":500}},{\"id\":2,\"required\":1,\"img\":{\"type\":3,\"wmin\":1,\"hmin\":1}},{\"id\":3,\"required\":0,\"data\":{\"type\":1,\"len\":200}},{\"id\":4,\"required\":0,\"data\":{\"type\":2,\"len\":15000}},{\"id\":5,\"required\":0,\"data\":{\"type\":6,\"len\":40}},{\"id\":6,\"required\":0,\"data\":{\"type\":500}}]}" + }, + "ext": { + "bidder": { + "publisher": "cafemom" + } + } + }, + { + "id": "test-imp-video-id", + "video": { + "mimes": ["video/mp4"], + "protocols": [2, 5], + "w": 1024, + "h": 576 + }, + "ext": { + "bidder": { + "publisher": "cafemom" + } + } + } + ] + }, + "httpCalls": [ + { + "expectedRequest": { + "uri": "http://east-bid.ybp.yahoo.com/bid/appnexuspbs?publisher=cafemom", + "body": { + "id": "test-request-id", + "at":1, + "imp": [ + { + "id": "test-imp-id", + "banner": { + "format": [ + { + "w": 300, + "h": 250 + }, + { + "w": 300, + "h": 600 + } + ] + }, + "ext": { + "bidder": { + "publisher": "cafemom" + } + } + }, + { + "id": "unsupported-native-imp", + "native": { + "ver": "1.1", + "request": "{\"ver\":\"1.1\",\"context\":1,\"contextsubtype\":11,\"assets\":[{\"id\":1,\"required\":1,\"title\":{\"len\":500}},{\"id\":2,\"required\":1,\"img\":{\"type\":3,\"wmin\":1,\"hmin\":1}},{\"id\":3,\"required\":0,\"data\":{\"type\":1,\"len\":200}},{\"id\":4,\"required\":0,\"data\":{\"type\":2,\"len\":15000}},{\"id\":5,\"required\":0,\"data\":{\"type\":6,\"len\":40}},{\"id\":6,\"required\":0,\"data\":{\"type\":500}}]}" + }, + "ext": { + "bidder": { + "publisher": "cafemom" + } + } + }, + { + "id": "test-imp-video-id", + "video": { + "mimes": ["video/mp4"], + "protocols": [2, 5], + "w": 1024, + "h": 576 + }, + "ext": { + "bidder": { + "publisher": "cafemom" + } + } + } + ] + } + }, + "mockResponse": { + "status": 200, + "body": { + "id": "test-request-id", + "seatbid": [ + { + "seat": "958", + "bid": [{ + "id": "7706636740145184841", + "impid": "test-imp-video-id", + "price": 0.500000, + "adid": "29681110", + "adm": "some-test-ad", + "adomain": ["yahoo.com"], + "cid": "958", + "crid": "29681110", + "h": 576, + "w": 1024 + }] + } + ], + "bidid": "5778926625248726496", + "cur": "USD" + } + } + } + ], + + "expectedBids": [ + { + "bid": { + "id": "7706636740145184841", + "impid": "test-imp-video-id", + "price": 0.5, + "adm": "some-test-ad", + "adid": "29681110", + "adomain": ["yahoo.com"], + "cid": "958", + "crid": "29681110", + "w": 1024, + "h": 576 + }, + "type": "video" + } + ] + +} diff --git a/adapters/brightroll/brightrolltest/exemplary/banner-video.json b/adapters/brightroll/brightrolltest/exemplary/banner-video.json index 9e13663a57e..aab6ad6a9bb 100644 --- a/adapters/brightroll/brightrolltest/exemplary/banner-video.json +++ b/adapters/brightroll/brightrolltest/exemplary/banner-video.json @@ -44,6 +44,7 @@ "uri": "http://east-bid.ybp.yahoo.com/bid/appnexuspbs?publisher=cafemom", "body": { "id": "test-request-id", + "at":1, "imp": [ { "id": "test-imp-id", diff --git a/adapters/brightroll/brightrolltest/exemplary/simple-banner.json b/adapters/brightroll/brightrolltest/exemplary/simple-banner.json index 1156739b055..118b6793dc0 100644 --- a/adapters/brightroll/brightrolltest/exemplary/simple-banner.json +++ b/adapters/brightroll/brightrolltest/exemplary/simple-banner.json @@ -31,6 +31,7 @@ "uri": "http://east-bid.ybp.yahoo.com/bid/appnexuspbs?publisher=cafemom", "body": { "id": "test-request-id", + "at":1, "imp": [ { "id": "test-imp-id", diff --git a/adapters/brightroll/brightrolltest/exemplary/simple-video.json b/adapters/brightroll/brightrolltest/exemplary/simple-video.json index c8e8ef06252..719d32fbf9a 100644 --- a/adapters/brightroll/brightrolltest/exemplary/simple-video.json +++ b/adapters/brightroll/brightrolltest/exemplary/simple-video.json @@ -25,6 +25,7 @@ "uri": "http://east-bid.ybp.yahoo.com/bid/appnexuspbs?publisher=cafemom", "body": { "id": "test-request-id", + "at":1, "imp": [ { "id": "test-imp-id", diff --git a/adapters/brightroll/brightrolltest/exemplary/valid-extension.json b/adapters/brightroll/brightrolltest/exemplary/valid-extension.json index ed60209cfab..068b3c68e49 100644 --- a/adapters/brightroll/brightrolltest/exemplary/valid-extension.json +++ b/adapters/brightroll/brightrolltest/exemplary/valid-extension.json @@ -25,6 +25,7 @@ "uri": "http://east-bid.ybp.yahoo.com/bid/appnexuspbs?publisher=cafemom", "body": { "id": "test-request-id", + "at":1, "imp": [ { "id": "test-imp-id", diff --git a/adapters/brightroll/brightrolltest/exemplary/video-and-audio.json b/adapters/brightroll/brightrolltest/exemplary/video-and-audio.json new file mode 100644 index 00000000000..88c9892454a --- /dev/null +++ b/adapters/brightroll/brightrolltest/exemplary/video-and-audio.json @@ -0,0 +1,110 @@ +{ + "mockBidRequest": { + "id": "test-request-id", + "imp": [ + { + "id": "test-imp-video-id", + "video": { + "mimes": ["video/mp4"], + "protocols": [2, 5], + "w": 1024, + "h": 576 + }, + "ext": { + "bidder": { + "publisher": "cafemom" + } + } + }, + { + "id": "unsupported-audio-imp", + "audio": { + "mimes": [ + "video/mp4" + ] + }, + "ext": { + "bidder": { + "publisher": "cafemom" + } + } + } + ] + }, + "httpCalls": [ + { + "expectedRequest": { + "uri": "http://east-bid.ybp.yahoo.com/bid/appnexuspbs?publisher=cafemom", + "body": { + "id": "test-request-id", + "at":1, + "imp": [ + { + "id": "test-imp-video-id", + "video": { + "mimes": ["video/mp4"], + "protocols": [2, 5], + "w": 1024, + "h": 576 + }, + "ext": { + "bidder": { + "publisher": "cafemom" + } + } + }, + { + "id": "unsupported-audio-imp", + "audio": { + "mimes": [ + "video/mp4" + ] + }, + "ext": { + "bidder": { + "publisher": "cafemom" + } + } + } + ] + } + }, + "mockResponse": { + "status": 200, + "body": { + "id": "test-request-id", + "cur": "USD", + "seatbid": [ + { + "seat": "brightroll", + "bid": [{ + "id": "8ee514f1-b2b8-4abb-89fd-084437d1e800", + "impid": "test-imp-video-id", + "price": 0.500000, + "adm": "some-test-ad", + "crid": "crid_10", + "w": 1024, + "h": 576 + }] + } + ] + } + } + } + ], + + "expectedBids": [ + { + "bid": { + "id": "8ee514f1-b2b8-4abb-89fd-084437d1e800", + "impid": "test-imp-video-id", + "price": 0.5, + "adm": "some-test-ad", + "crid": "crid_10", + "w": 1024, + "h": 576 + }, + "type": "video" + } + ] +} diff --git a/adapters/eplanning/eplanningtest/exemplary/simple-banner.json b/adapters/eplanning/eplanningtest/exemplary/simple-banner.json index 069469558b1..2d277bdc235 100644 --- a/adapters/eplanning/eplanningtest/exemplary/simple-banner.json +++ b/adapters/eplanning/eplanningtest/exemplary/simple-banner.json @@ -31,6 +31,7 @@ "uri": "http://ads.us.e-planning.net/dsp/obr/1/123", "body": { "id": "test-request-id", + "at":1, "imp": [ { "id": "test-imp-id", From 63300ce505996134f097fc591d71228c245babe9 Mon Sep 17 00:00:00 2001 From: smithaa Date: Fri, 9 Nov 2018 16:20:13 -0800 Subject: [PATCH 2/3] fixed merge issue --- .../brightrolltest/exemplary/banner-native-audio.json | 4 +++- .../brightrolltest/exemplary/banner-video-native.json | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/adapters/brightroll/brightrolltest/exemplary/banner-native-audio.json b/adapters/brightroll/brightrolltest/exemplary/banner-native-audio.json index 0c4749761dc..fe10320c70f 100644 --- a/adapters/brightroll/brightrolltest/exemplary/banner-native-audio.json +++ b/adapters/brightroll/brightrolltest/exemplary/banner-native-audio.json @@ -69,7 +69,9 @@ "w": 300, "h": 600 } - ] + ], + "w": 300, + "h": 250 }, "ext": { "bidder": { diff --git a/adapters/brightroll/brightrolltest/exemplary/banner-video-native.json b/adapters/brightroll/brightrolltest/exemplary/banner-video-native.json index 6622887fb93..ede5c4c1ff1 100644 --- a/adapters/brightroll/brightrolltest/exemplary/banner-video-native.json +++ b/adapters/brightroll/brightrolltest/exemplary/banner-video-native.json @@ -70,7 +70,9 @@ "w": 300, "h": 600 } - ] + ], + "w": 300, + "h": 250 }, "ext": { "bidder": { From 5f5353b41576b035e59a3318bbdcf96d26f05a04 Mon Sep 17 00:00:00 2001 From: smithaa Date: Fri, 9 Nov 2018 16:23:08 -0800 Subject: [PATCH 3/3] removed unnessary code --- adapters/eplanning/eplanningtest/exemplary/simple-banner.json | 1 - 1 file changed, 1 deletion(-) diff --git a/adapters/eplanning/eplanningtest/exemplary/simple-banner.json b/adapters/eplanning/eplanningtest/exemplary/simple-banner.json index 2d277bdc235..069469558b1 100644 --- a/adapters/eplanning/eplanningtest/exemplary/simple-banner.json +++ b/adapters/eplanning/eplanningtest/exemplary/simple-banner.json @@ -31,7 +31,6 @@ "uri": "http://ads.us.e-planning.net/dsp/obr/1/123", "body": { "id": "test-request-id", - "at":1, "imp": [ { "id": "test-imp-id",