-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from latest to a versioned release scheme #187
Comments
Thank you for expanding on this! I like the idea of making it a config option, but I have questions:
|
Disabling should definitely be possible 👍 About the version granularity. I really like the idea of having
All the decision logic which version is in prebid. However what this doesn't provide is a mean of hotfixing a specific version. The same is true for prebid. And because the default puc version is configured in prebid, I would argue this is okay. |
The (possible) issue with that is every pub needs to keep up with which particular PUC version is the "correct" version for their Prebid deployment. It may go too far in the other direction, compared to now where most pubs get all updates automatically. For example:
The alternative would be:
|
The current proposal is to add a configuration option to pbjs that passes the puc version in ad server targeting and recommend users adjust their puc to stop pointing to latest and use the macro. Each prebid js release would default to point to a particular latest puc release if a publisher is opting into passing that, indicating they use the puc. |
We should update PUC to pick up the same rendering logic merged with prebid/Prebid.js#10819 |
Currently PUC guarantees 100% backwards compatibility for eternity due to the fact
that an unknown, but properly huge portion of publishers use the
latest.js
PUC script.This means that every change in PUC must not break any existing integrations, which comes at a cost
@dgirardi already made a good proposal in this comment
I would like to extend this proposal a bit and elaborate why.
Proposal
TL;DR: The general idea from @dgirardi remains the same. A key value can be used to determine the PUC version, but it's configurable in prebid.js with a sensible default.
Background
We are currently using a fixed version like this
and upgrade creatives when we see a necessity. A fixed identifier comes with the benefit of
Upgrades are done via the GAM API, which many publishers don't have the resources to integrate.
Configurable PUC version in prebid
If the PUC version would be configurable inside prebid with something like
this would allow us to
The
puc.version
property would be set as a targeting parameter. For google ad manager this can be done on a page-level, e.ghb_puc_ver
.The text was updated successfully, but these errors were encountered: