Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404's from module page after the recent update #3295

Closed
jsut opened this issue Sep 27, 2021 · 5 comments · Fixed by #3296
Closed

404's from module page after the recent update #3295

jsut opened this issue Sep 27, 2021 · 5 comments · Fixed by #3296

Comments

@jsut
Copy link
Contributor

jsut commented Sep 27, 2021

https://docs.prebid.org/dev-docs/modules/index.html now has a bunch of links that 404 on it, where the filename of the markdown file that is being linked to differs from the module_code in the the markdown. examples are:

GPT Pre-Auction, both bidViewability modules, price Floors, Google Ad Manager Express, Google Ad Manager Video Support, Freewheel Video Support, Konduit Accelerate

@jsut
Copy link
Contributor Author

jsut commented Sep 27, 2021

@bretg fyi

@bretg
Copy link
Contributor

bretg commented Sep 29, 2021

thanks @jsut for pointing it out and the fix. Gonna use this page.url in other places.

@jsut
Copy link
Contributor Author

jsut commented Oct 1, 2021

@bretg should this have auto deployed to the site? docs.prebid.org still has the 404's

@bretg
Copy link
Contributor

bretg commented Oct 2, 2021

ugh - there are 3 groups of modules -- just pushed a change for the two other blocks

@jsut
Copy link
Contributor Author

jsut commented Oct 2, 2021

ahh, i should have looked harder at the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants