From 6fe5a535b283787d71f0c23e1b1891f91e3c5a19 Mon Sep 17 00:00:00 2001 From: Mitesh Thakor Date: Wed, 15 Apr 2020 13:43:30 +0530 Subject: [PATCH 1/4] update dailyhunt doc --- dev-docs/bidders/dailyhunt.md | 62 ++++++++++++++++++++++++++++------- 1 file changed, 51 insertions(+), 11 deletions(-) diff --git a/dev-docs/bidders/dailyhunt.md b/dev-docs/bidders/dailyhunt.md index aef1a5ac91..ef59d055ef 100644 --- a/dev-docs/bidders/dailyhunt.md +++ b/dev-docs/bidders/dailyhunt.md @@ -4,34 +4,50 @@ title: Dailyhunt description: Prebid Dailyhunt Bidder Adaptor hide: true biddercode: dailyhunt -media_types: display, native +media_types: display, native, video gdpr_supported: true --- ### Bid Params {: .table .table-bordered .table-striped } -| Name | Scope | Description | Example | Type | -|-------------------|----------|----------------------------------------------------------------------------------------------------------------------|-----------------------------------------------|------------| -| `partnerId` | required | Serving ads based on partnerId. Contact Dailyhunt for PartnerIds. | `'pb-partner'` | `string` | +| Name | Scope | Description | Example | Type | +|------|----------|-------------|---------|------| +| `placement_id` | required | Serving ads based on placement_id. Contact Dailyhunt for publisher_id. | `1` | `int` | +| `publisher_id` | required | Serving ads based on publisher_id. Contact Dailyhunt for publisher_id. | `1` | `int` | +| `test_mode` | optional | Serving test mode campaign only. | `true` | `bool` | +| `bidfloor` | optional | Minimum bid for this bid expressed in CPM. | `1.4` | `float` | +| `video` | optional | A Video object required if this bid is offered as a video ad opportunity. It is ortb video object. | `video: { w: 640, h: 480, mimes: ["video/mp4"] }` | `object` | +|`site` | optional | Details about the publisher’s website. It is ortb site object. | `site:{id:"102855",cat:["IAB3-1"],domain:"http://m.dailyhunt.in",page:"http://m.dailyhunt.in/1234.html "}` | `object` | +| `device` | optional | Details about the user’s device to which the impression will be delivered. It is ortb device object. | `device: { ip: "64.124.253.1", os: "OS X", ua: "Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.16) }` | `object` | +| `user` | optional | Details about the human user of the device; the advertising audience. It is ortb user object. | `user: { id: "456789876567897654678987656789", gender: "M", gender: 1990, keywords: "marketing,traveling,reading" }` | `object` | +| `publisher` | optional | Details about the Publisher of the site. It is ortb publisher object. | `publisher: { id: "8953", name: "dailyhunt", "cat": [ "IAB3-1" ], "domain": "m.dailyhunt.in" }` | `object` | -### Test Parameters +**Notes: `video`, `site`, `device`, `user`, `publisher` these objects are ortb object so you can refer ortb documentation. [ORTB DOC](url_link)** + +# Test Parameters ``` var adUnits = [ { - code: 'test-banner-adunit-code', + code: '/83414793/prebid_test_display', sizes: [[300, 250], [320, 50]], + mediaTypes: { + banner : { + sizes: [[300, 250], [320, 50]], + } + }, bids: [ { bidder: 'dailyhunt', params: { - partnerId: 'pb-partnerId' + placement_id: 1, + publisher_id: 1 } } ] }, { - code: 'test-native-adunit-code', + code: '/83414793/prebid_test_native', sizes: [[300, 250]], mediaTypes: { native: { @@ -44,16 +60,40 @@ gdpr_supported: true image: { required: true }, - sponsoredBy: { + cta: { required: true - }, + } + } + }, + bids: [ + { + bidder: 'dailyhunt', + params: { + placement_id: 1, + publisher_id: 1 + } + } + ] + }, + { + code: '/83414793/prebid_test_video', + mediaTypes: { + video: { + playerSize: [1280, 720], + context: 'instream' } }, bids: [ { bidder: 'dailyhunt', params: { - partnerId: 'pb-partnerId' + placement_id: 1, + publisher_id: 1, + video: { + mimes: [ + 'video/mp4' + ] + } } } ] From 0303102f5e1a628979c7c5f56917fb213cdaf788 Mon Sep 17 00:00:00 2001 From: Mitesh Thakor Date: Tue, 12 May 2020 17:39:03 +0530 Subject: [PATCH 2/4] change docs --- dev-docs/bidders/dailyhunt.md | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/dev-docs/bidders/dailyhunt.md b/dev-docs/bidders/dailyhunt.md index ef59d055ef..04746fdbdc 100644 --- a/dev-docs/bidders/dailyhunt.md +++ b/dev-docs/bidders/dailyhunt.md @@ -13,8 +13,9 @@ gdpr_supported: true {: .table .table-bordered .table-striped } | Name | Scope | Description | Example | Type | |------|----------|-------------|---------|------| -| `placement_id` | required | Serving ads based on placement_id. Contact Dailyhunt for publisher_id. | `1` | `int` | +| `placement_id` | required | Serving ads based on placement_id. Contact Dailyhunt for placement_id. | `1` | `int` | | `publisher_id` | required | Serving ads based on publisher_id. Contact Dailyhunt for publisher_id. | `1` | `int` | +| `partner_name` | required | Serving ads based on partner_name. Contact Dailyhunt for partner_name. | `dailyhunt` | `string` | | `test_mode` | optional | Serving test mode campaign only. | `true` | `bool` | | `bidfloor` | optional | Minimum bid for this bid expressed in CPM. | `1.4` | `float` | | `video` | optional | A Video object required if this bid is offered as a video ad opportunity. It is ortb video object. | `video: { w: 640, h: 480, mimes: ["video/mp4"] }` | `object` | @@ -23,7 +24,7 @@ gdpr_supported: true | `user` | optional | Details about the human user of the device; the advertising audience. It is ortb user object. | `user: { id: "456789876567897654678987656789", gender: "M", gender: 1990, keywords: "marketing,traveling,reading" }` | `object` | | `publisher` | optional | Details about the Publisher of the site. It is ortb publisher object. | `publisher: { id: "8953", name: "dailyhunt", "cat": [ "IAB3-1" ], "domain": "m.dailyhunt.in" }` | `object` | -**Notes: `video`, `site`, `device`, `user`, `publisher` these objects are ortb object so you can refer ortb documentation. [ORTB DOC](url_link)** +**Notes: `video`, `site`, `device`, `user`, `publisher` these objects are ortb object so you can refer ortb documentation. [ORTB DOC](https://www.iab.com/wp-content/uploads/2016/03/OpenRTB-API-Specification-Version-2-5-FINAL.pdf)** # Test Parameters ``` @@ -41,7 +42,8 @@ gdpr_supported: true bidder: 'dailyhunt', params: { placement_id: 1, - publisher_id: 1 + publisher_id: 1, + partner_name: 'dailyhunt' } } ] @@ -70,7 +72,8 @@ gdpr_supported: true bidder: 'dailyhunt', params: { placement_id: 1, - publisher_id: 1 + publisher_id: 1, + partner_name: 'dailyhunt' } } ] @@ -89,6 +92,7 @@ gdpr_supported: true params: { placement_id: 1, publisher_id: 1, + partner_name: 'dailyhunt', video: { mimes: [ 'video/mp4' From 4a04dad4c5a6f3ca0a10174adb8d4a390338c151 Mon Sep 17 00:00:00 2001 From: Mitesh Thakor Date: Wed, 13 May 2020 17:23:59 +0530 Subject: [PATCH 3/4] update doc --- dev-docs/bidders/dailyhunt.md | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/dev-docs/bidders/dailyhunt.md b/dev-docs/bidders/dailyhunt.md index 04746fdbdc..dc9ba60622 100644 --- a/dev-docs/bidders/dailyhunt.md +++ b/dev-docs/bidders/dailyhunt.md @@ -43,7 +43,10 @@ gdpr_supported: true params: { placement_id: 1, publisher_id: 1, - partner_name: 'dailyhunt' + partner_name: 'dailyhunt', + device: { + ip: "182.23.143.212" + } } } ] @@ -73,7 +76,10 @@ gdpr_supported: true params: { placement_id: 1, publisher_id: 1, - partner_name: 'dailyhunt' + partner_name: 'dailyhunt', + device: { + ip: "182.23.143.212" + } } } ] @@ -93,6 +99,9 @@ gdpr_supported: true placement_id: 1, publisher_id: 1, partner_name: 'dailyhunt', + device: { + ip: "182.23.143.212" + }, video: { mimes: [ 'video/mp4' From 7f605777e99ac107abd270393884a5c8c891d528 Mon Sep 17 00:00:00 2001 From: Mitesh Thakor Date: Wed, 13 May 2020 19:09:46 +0530 Subject: [PATCH 4/4] fix reviewer chnages --- dev-docs/bidders/dailyhunt.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev-docs/bidders/dailyhunt.md b/dev-docs/bidders/dailyhunt.md index dc9ba60622..ad6b6faee8 100644 --- a/dev-docs/bidders/dailyhunt.md +++ b/dev-docs/bidders/dailyhunt.md @@ -24,7 +24,7 @@ gdpr_supported: true | `user` | optional | Details about the human user of the device; the advertising audience. It is ortb user object. | `user: { id: "456789876567897654678987656789", gender: "M", gender: 1990, keywords: "marketing,traveling,reading" }` | `object` | | `publisher` | optional | Details about the Publisher of the site. It is ortb publisher object. | `publisher: { id: "8953", name: "dailyhunt", "cat": [ "IAB3-1" ], "domain": "m.dailyhunt.in" }` | `object` | -**Notes: `video`, `site`, `device`, `user`, `publisher` these objects are ortb object so you can refer ortb documentation. [ORTB DOC](https://www.iab.com/wp-content/uploads/2016/03/OpenRTB-API-Specification-Version-2-5-FINAL.pdf)** +**Notes: The `video`, `site`, `device`, `user`, `publisher` objects are all ORTB objects. Please refer to the [ORTB documentation](https://www.iab.com/wp-content/uploads/2016/03/OpenRTB-API-Specification-Version-2-5-FINAL.pdf) for additional details.** # Test Parameters ```