Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loglylift adapter #3429

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Loglylift adapter #3429

merged 2 commits into from
Jan 6, 2022

Conversation

HashimotoLogly
Copy link
Contributor

@HashimotoLogly HashimotoLogly commented Nov 26, 2021

Add Loglylift bid adapter dev-docs

Adapter PR: prebid/Prebid.js#7761

coppa_supported: false
schain_supported: false
dchain_supported: false
media_types: no-display, native
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if no-display is required here. Only native should be sufficient. @bretg any objections?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they don't support display, then yes, "no-display" is appropriate. This is because the default metadata table in pbs-bidders.md assumes everyone supports display. This was easier than trying to get answers for 300 bidders about what media types they supported.

Copy link
Contributor Author

@HashimotoLogly HashimotoLogly Dec 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bretg
Hello.
Is this still under discussion?

Our adapter is designed to support only native format. And I just follow this example.
Banners_and_Alerts_と_How_to_Add_a_New_Prebid_js_Bidder_Adapter_for_Header_Bidding

In what case, should "display" be noted as supported media_types? What "display" exactly means?

@bretg
Copy link
Contributor

bretg commented Dec 14, 2021

This PR is fine @HashimotoLogly . We'll merge it when the next PBJS release goes out.

What "display" exactly means?

The openrtb 'banner' mediatype.

@fowler446 fowler446 merged commit ad2b34e into prebid:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants