Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeta Global SSP Analytics Adapter: add docs for new analytics adapter #3460

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Zeta Global SSP Analytics Adapter: add docs for new analytics adapter #3460

merged 2 commits into from
Jan 14, 2022

Conversation

abermanov-zeta
Copy link
Contributor

No description provided.

Copy link
Collaborator

@MartianTribe MartianTribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add either or both:
pbs:true
pbjs:true

as well as the version you support:

pbjs_version_notes: vx.xx and later

to the front matter.

@abermanov-zeta
Copy link
Contributor Author

abermanov-zeta commented Jan 5, 2022

@MartianTribe Thank you for your review. I've added the requested fields. Could you please review it again?

I'd like to mention that there is no a word about those fields in the doc here - https://docs.prebid.org/dev-docs/integrate-with-the-prebid-analytics-api.html#step-5-website-pull-request , also I could not find them in any other analytics adapter docs in the repo. These fields are mentioned in docs related to bidder adapters only. It's a bit confusing :)

Thank you.

@bretg
Copy link
Contributor

bretg commented Jan 14, 2022

Being an analytics adapter, the pbjs: true flag is unnecessary, but is fine. Going to talk to the website team about whether pbjs_version_notes is really required. It's useful, sure, but I agree that if it's required, needs to be in the docs.

@bretg bretg merged commit 4d8eebb into prebid:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants