Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed cpexId to czechAdId #4286

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Conversation

EskelCz
Copy link
Contributor

@EskelCz EskelCz commented Jan 18, 2023

Docs changes for this PR: prebid/Prebid.js#9433

🏷 Type of documentation

updated user id submodule

📋 Checklist

@netlify
Copy link

netlify bot commented Jan 18, 2023

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit efe9ab2
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/63c805ce3a4cee0009eeda2d
😎 Deploy Preview https://deploy-preview-4286--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bretg
Copy link
Contributor

bretg commented Jan 24, 2023

See the code PR for concerns about renaming modules outside of major releases.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine assuming that it's going to wait for Prebid.js 8.0. If you don't want to wait, then you can update the PR to add the new name alongside the old name.

@bretg
Copy link
Contributor

bretg commented Jun 15, 2023

Merging. The comment in the code PR was "the only partner using the module at the moment is Czech News Center a.s.. We're in close contact with them and the system is not yet in production."

@bretg bretg merged commit 620f169 into prebid:master Jun 15, 2023
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants