Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AdSparc and Insticator. #470

Merged
merged 4 commits into from
Dec 14, 2017

Conversation

jcswart
Copy link
Contributor

@jcswart jcswart commented Nov 30, 2017

Adding documentation for aliases: AdSparc and Insticator.

Should be merged once: prebid/Prebid.js#1802 is accepted.

@jcswart jcswart mentioned this pull request Dec 2, 2017
9 tasks
@rmloveland
Copy link
Contributor

Hi @jcswart would it be correct to say that these aliases are 1.0-compliant, since the Serverbid adapter is?

If so can you please update this PR with the following added line to the YAML at the top of each file?

prebid_1_0_supported : true

This is used to make sure these adapters show up when you select 1.0 from the dropdown menu on the downloads page.

@jcswart
Copy link
Contributor Author

jcswart commented Dec 14, 2017

@rmloveland Thank you, was wondering about this! I will make that change now!

@jcswart
Copy link
Contributor Author

jcswart commented Dec 14, 2017

@rmloveland Changes made, thank you for telling me about this!

@jcswart
Copy link
Contributor Author

jcswart commented Dec 14, 2017

Let me go ahead and actually add this tag to all of our adapter's yaml as well.

@jcswart
Copy link
Contributor Author

jcswart commented Dec 14, 2017

Okay, I've included this flag on all of our aliases and added a doc file for an alias that was missing.

@jcswart jcswart force-pushed the add-insticator-adsparc branch from d5f23de to 467a4eb Compare December 14, 2017 17:55
@rmloveland rmloveland self-assigned this Dec 14, 2017
@rmloveland rmloveland merged commit b8c8789 into prebid:master Dec 14, 2017
@rmloveland
Copy link
Contributor

Thanks @jcswart - just merged, should be showing up on the site in a few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants