-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cwire adapter: Update tcfeu_supported field (c-wire/support#117) #5167
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -5,7 +5,7 @@ description: C-WIRE Prebid Bidder Adapter | |||
pbjs: true | |||
pbs: true | |||
biddercode: cwire | |||
tcfeu_supported: false | |||
tcfeu_supported: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to claim tcfeu_supported
you need a gvl_id
. Otherwise the consent cannot be validated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The id is 1081. Where should we provide it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @muuki88
Thanks for the review. Do you need anything more from us?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tcfeu_supported: true | |
tcfeu_supported: true | |
gvl_id: 1081 |
please add this then 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-Is this also present in your prebid adapter?-
No, it's not: https://github.com/prebid/Prebid.js/blob/master/modules/cwireBidAdapter.js#L143
you should add the gvlid
to your adapter spec. Otherwise you will not receive any bids, when gdpr applies and the gdprEnforcementModule is included.
See rubicon for an example
https://github.com/prebid/Prebid.js/blob/0210d2eeb5639753e1e39ad0069ea69325d60e2c/modules/rubiconBidAdapter.js#L247
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On it.. thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR created for the adapter:
prebid/Prebid.js#11181
🏷 Type of documentation
Updated
tcfeu_supported: true
in CWire's adapter docs.