Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cwire adapter: Update tcfeu_supported field (c-wire/support#117) #5167

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

espen-j
Copy link
Contributor

@espen-j espen-j commented Feb 21, 2024

🏷 Type of documentation

Updated tcfeu_supported: true in CWire's adapter docs.

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 1076ccd
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/65e996cdd610930008d3aacd
😎 Deploy Preview https://deploy-preview-5167--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -5,7 +5,7 @@ description: C-WIRE Prebid Bidder Adapter
pbjs: true
pbs: true
biddercode: cwire
tcfeu_supported: false
tcfeu_supported: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to claim tcfeu_supported you need a gvl_id . Otherwise the consent cannot be validated.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The id is 1081. Where should we provide it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @muuki88
Thanks for the review. Do you need anything more from us?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tcfeu_supported: true
tcfeu_supported: true
gvl_id: 1081

please add this then 😄

Copy link
Contributor

@muuki88 muuki88 Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Is this also present in your prebid adapter?-

No, it's not: https://github.com/prebid/Prebid.js/blob/master/modules/cwireBidAdapter.js#L143

you should add the gvlid to your adapter spec. Otherwise you will not receive any bids, when gdpr applies and the gdprEnforcementModule is included.

See rubicon for an example
https://github.com/prebid/Prebid.js/blob/0210d2eeb5639753e1e39ad0069ea69325d60e2c/modules/rubiconBidAdapter.js#L247

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it.. thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR created for the adapter:
prebid/Prebid.js#11181

@muuki88 muuki88 merged commit 3f57034 into prebid:master Mar 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants