Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Bid Adapter] JW Player Bid Adapter #5256

Merged
merged 4 commits into from
May 2, 2024

Conversation

karimMourra
Copy link
Contributor

@karimMourra karimMourra commented Apr 15, 2024

🏷 Type of documentation

  • new bid adapter

📋 Checklist

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 49a11ec
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/662a7c2e6e47070008c4be2a
😎 Deploy Preview https://deploy-preview-5256--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dev-docs/bidders/jwplayer.md Outdated Show resolved Hide resolved
dev-docs/bidders/jwplayer.md Outdated Show resolved Hide resolved
dev-docs/bidders/jwplayer.md Outdated Show resolved Hide resolved
dev-docs/bidders/jwplayer.md Outdated Show resolved Hide resolved
@bretg
Copy link
Contributor

bretg commented Apr 24, 2024

Also - please remove the extra blank line that's causing the linting error

@karimMourra karimMourra force-pushed the feature/jwplayer-adapter branch from af32470 to 49a11ec Compare April 25, 2024 15:52
@karimMourra
Copy link
Contributor Author

@bretg thanks for the review, feedback addressed

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates @karimMourra

@bretg bretg added LGTM and removed needs work labels Apr 25, 2024
@ChrisHuie ChrisHuie merged commit 7110ab2 into prebid:master May 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants