Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to JSFiddle examples for multiformat updates #577

Merged
merged 3 commits into from
Feb 12, 2018

Conversation

jsnellbaker
Copy link
Contributor

As a follow-up to the #528, these are additional updates for the multiformat changes - notably updates to the various JSFiddles used across the dev-docs/examples area of the site.

@rmloveland
Copy link
Contributor

Hi @jsnellbaker unfortunately a lot of the updated fiddles don't seem to work, and I'm not sure why. I took screenshots of what's on master vs. what's in this PR, which I'll attach below. It's possible I'm missing something obvious, so please let me know.

adjust-price-577.png

adjust-price-577

adjust-price-master.png

adjust-price-master

adunit-refresh-577.png

adunit-refresh-577

adunit-refresh-master.png

adunit-refresh-master

basic-example-577.png

basic-example-577

basic-example-master.png

basic-example-master

brightcove-577.png

brightcove-577

brightcove-master.png

brightcove-master

custom-price-bucket-577.png

custom-price-bucket-577

custom-price-bucket-master.png

custom-price-bucket-master

custom-price-bucket-using-setpricegranularity-577.png

custom-price-bucket-using-setpricegranularity-577

custom-price-bucket-using-setpricegranularity-master.png

custom-price-bucket-using-setpricegranularity-master

full-page-refresh-577.png

full-page-refresh-577

full-page-refresh-master.png

full-page-refresh-master

@jsnellbaker
Copy link
Contributor Author

Hi @rmloveland, I went through the various fiddles and found the issue. These pages were pointing to the legacy 0.34.x branch instead of the current 1.x branch, which contains the functionality to use this new syntax style. I went through all the fiddles again and converted them to the 1.x format and verified they are working again.

Note as part of these updates, certain pages had other aspects of the code also updated to the 1.x version of the functionality (such as using setConfig() instead of using a new depreciated method directly).

Please let me know if you have questions or still see any problems. Thanks.

Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all of your work on these updates @jsnellbaker !

@rmloveland rmloveland merged commit 8a0f573 into master Feb 12, 2018
@rmloveland rmloveland deleted the more_multiformat_updates branch February 12, 2018 20:01
rmloveland pushed a commit that referenced this pull request Feb 14, 2018
* updates to JSFiddle examples for multiformat updates

* updating pages with new fiddle that is 1.x compliant

* fixing broken fiddle links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants