From 62ea47c6690ad5e902fa1e47a79fd675399ad3dc Mon Sep 17 00:00:00 2001 From: Meng <5110935+edmonl@users.noreply.github.com> Date: Mon, 12 Apr 2021 17:28:19 -0400 Subject: [PATCH] pubGENIUS bid adapter: support floor module (#6555) --- modules/pubgeniusBidAdapter.js | 15 +++++++++++---- modules/pubgeniusBidAdapter.md | 4 ---- test/spec/modules/pubgeniusBidAdapter_spec.js | 4 ++-- 3 files changed, 13 insertions(+), 10 deletions(-) diff --git a/modules/pubgeniusBidAdapter.js b/modules/pubgeniusBidAdapter.js index 5c750e66c25..2df2d25f627 100644 --- a/modules/pubgeniusBidAdapter.js +++ b/modules/pubgeniusBidAdapter.js @@ -7,8 +7,8 @@ import { deepSetValue, inIframe, isArrayOfNums, + isFn, isInteger, - isNumber, isStr, logError, parseQueryStringParameters, @@ -185,9 +185,16 @@ function buildImp(bid) { imp.video = buildVideoParams(bid.mediaTypes.video, bid.params.video); } - const bidFloor = bid.params.bidFloor; - if (isNumber(bidFloor)) { - imp.bidfloor = bidFloor; + if (isFn(bid.getFloor)) { + const { floor } = bid.getFloor({ + mediaType: bid.mediaTypes.banner ? 'banner' : 'video', + size: '*', + currency: 'USD', + }); + + if (floor) { + imp.bidfloor = floor; + } } const pos = bid.params.position; diff --git a/modules/pubgeniusBidAdapter.md b/modules/pubgeniusBidAdapter.md index ff23a433331..66e0c382285 100644 --- a/modules/pubgeniusBidAdapter.md +++ b/modules/pubgeniusBidAdapter.md @@ -12,8 +12,6 @@ Module that connects to pubGENIUS's demand sources # Test Parameters -Test bids have $0.01 CPM by default. Use `bidFloor` in bidder params to control CPM for testing purposes. - ``` var adUnits = [ { @@ -45,7 +43,6 @@ var adUnits = [ bidder: 'pubgenius', params: { adUnitId: '1000', - bidFloor: 0.5, test: true } } @@ -66,7 +63,6 @@ var adUnits = [ bidder: 'pubgenius', params: { adUnitId: '1001', - bidFloor: 1, test: true, // other video parameters as in OpenRTB v2.5 spec diff --git a/test/spec/modules/pubgeniusBidAdapter_spec.js b/test/spec/modules/pubgeniusBidAdapter_spec.js index 382199dcffc..57b83fced06 100644 --- a/test/spec/modules/pubgeniusBidAdapter_spec.js +++ b/test/spec/modules/pubgeniusBidAdapter_spec.js @@ -225,8 +225,8 @@ describe('pubGENIUS adapter', () => { expect(buildRequests([bidRequest, bidRequest1], bidderRequest)).to.deep.equal(expectedRequest); }); - it('should take bid floor in bidder params', () => { - bidRequest.params.bidFloor = 0.5; + it('should take bid floor from getFloor interface', () => { + bidRequest.getFloor = () => ({ floor: 0.5, currency: 'USD' }); expectedRequest.data.imp[0].bidfloor = 0.5; expect(buildRequests([bidRequest], bidderRequest)).to.deep.equal(expectedRequest);