Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create android-arm and android-arm64 images #2

Closed
vweevers opened this issue Jan 27, 2019 · 2 comments
Closed

Create android-arm and android-arm64 images #2

vweevers opened this issue Jan 27, 2019 · 2 comments
Assignees

Comments

@vweevers
Copy link
Member

See also Level/leveldown#587 (comment). They must have:

ENV GYP_DEFINES target_arch=arm(64) android_target_arch=arm(64) host_os=linux OS=android.

Note:

  • IIRC you only need quotes around the value if you use the GYP_DEFINES= form, rather than GYP_DEFINES<space>
  • OS must be uppercase
  • target_arch might not be necessary, because we're also passing an ARCH (I didn't test without yet)
@ralphtheninja
Copy link
Member

We might not need target_arch since prebuildify sets it here https://github.com/prebuild/prebuildify/blob/master/index.js#L124

@ralphtheninja ralphtheninja self-assigned this Jan 27, 2019
@ralphtheninja
Copy link
Member

ralphtheninja commented Jan 27, 2019

dc3a112 and bd98af3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants