Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for build_from_source=true inside .npmrc #98

Closed
adipascu opened this issue Apr 5, 2019 · 2 comments
Closed

Add support for build_from_source=true inside .npmrc #98

adipascu opened this issue Apr 5, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@adipascu
Copy link
Contributor

adipascu commented Apr 5, 2019

I have a .npmrc file similar to this one:

runtime=electron
disturl=https://atom.io/download/electron
target=3.1.8
build_from_source=true

build_from_source=true forces a full rebuild while using node-pre-gyp (it happens here).
More information can be found on the web under the npm_config_build_from_source env variable.
@vweevers
Copy link
Member

vweevers commented Apr 5, 2019

Are you up for making a PR?

@vweevers vweevers added the enhancement New feature or request label Apr 5, 2019
@adipascu adipascu mentioned this issue Apr 5, 2019
Merged
@adipascu
Copy link
Contributor Author

adipascu commented Apr 5, 2019

@vweevers PR is done at #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adipascu @vweevers