Makefiles not compatible with Cmder (a Windows console emulator)

[tdesveauxPKFX]

From #1091, Makefiles generated with Premake uses wrong mkdir command due to mis-identification of shell.

Here is a snippet that could replace the current identification that works with cmd.exe, Powershell, Cmder and Mingw.

SHELLTYPE := posix
ifeq (.exe,$(findstring .exe,$(ComSpec)))
  SHELLTYPE := msdos
endif

which would replace this:

premake-core/modules/gmake2/gmake2.lua

Lines 275 to 284 in ff732af

	function gmake2.shellType()
	_p('SHELLTYPE := msdos')
	_p('ifeq (,$(ComSpec)$(COMSPEC))')
	_p(' SHELLTYPE := posix')
	_p('endif')
	_p('ifeq (/bin,$(findstring /bin,$(SHELL)))')
	_p(' SHELLTYPE := posix')
	_p('endif')
	_p('')
	end

Just checking I'm not missing something before submitting a PR.

[samsinsane]

The Cmder website says:

you will have all Unix commands

The Unix mkdir supports -p, so this sounds like a bug in Cmder not Premake.

[tdesveauxPKFX]

Well, you have access to all Unix commands but as mkdir is present in both Unix and msdos, the behavior is to use msdos mkdir.
As an example, you can both use del and rm in Cmder.

[samsinsane]

I don't see how you can have access to all Unix commands if mkdir isn't the Unix version. Anyway, as long as your change doesn't break Git Bash, it doesn't really bother me. 👍

[tdesveauxPKFX]

It's not that you don't have access to it but since there is a "conflict" due to the same name, the msdos command take priority.

It doesn't break Git Bash and shouldn't break Linux nor Unix in general.
I will submit a PR for this later.

[tdesveauxPKFX]

Fixed by #1103