-
-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable /Wall in msc #709
Comments
I need this too. msdn noted:
you can test it. |
Can you submit a PR to change the mapping for |
@starkos what reason you don't believe |
If you do this please do not make the only options /W0 and /Wall. Most projects do not need /Wall. The msvc STL is only tested so that it doesn't emit /W4 errors. The visual c++ team generally recommends that you don't use /Wall all the time. Only occasionally when you need extra checks. I suggest the following options:
/W4 is similar to gcc's -Wall, and /Wall is similar to gcc's -Wextra. |
Also, theres the /permissive- option in VS2017 which makes the compiler standards conformant, and produces errors for microsoft specific extensions to c++ https://blogs.msdn.microsoft.com/vcblog/2016/11/16/permissive-switch/ |
@amc522 NO, |
@leeonix I understand that /Wall is currently not in premake 5. I was just saying that if it does get added, please keep /W4 available. |
@amc522 OK. |
@leeonix: thank you. This workaround is working~ |
For my project I would like to crank the warning level up to the maximum with /Wall. it seems like that
warnings { "Extra" }
only activates warning level 4 and I have to manually bump the warning level in my project properties.I tried to override the warning level with the command
buildoptions { "/Wall" }
in my project, but it doesn't seem to work.
Are there other ways to set the /Wall flag?
The text was updated successfully, but these errors were encountered: