Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cppdialect "C++11" generates CLANG_CXX_LANGUAGE_STANDARD = "C++11" (uppercase) for Xcode 4 #895

Closed
hsandt opened this issue Sep 16, 2017 · 1 comment
Closed

cppdialect "C++11" generates CLANG_CXX_LANGUAGE_STANDARD = "C++11" (uppercase) for Xcode 4 #895

hsandt opened this issue Sep 16, 2017 · 1 comment
Labels
bug xcode

Comments

@hsandt
Copy link
Contributor

hsandt commented Sep 16, 2017 •
edited
Loading

Both cppdialect "C++11" and cppdialect "c++11", resp. 14, 17 generate build configurations CLANG_CXX_LANGUAGE_STANDARD = "C++11" (always uppercase), resp. 14, 17 when using premake xcode4. Similarly, cpdialect "C11" gives GCC_C_LANGUAGE_STANDARD = "C11". gnu variants are always lowercase and don't have that issue.

I spotted the cause of the bug in modules/xcode/xcode_common.lua and I am working on a fix. I'll send a PR as soon as it gets ready.

Note: Before this commit, the lower method was used at some places but when using flags, it wasn't, so the bug seems to come from before the introduction of cppdialect.
@hsandt hsandt mentioned this issue Sep 20, 2017
Merged
@hsandt
Copy link
Contributor Author

hsandt commented Oct 14, 2017

Resolved #897

@hsandt hsandt closed this as completed Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug xcode
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hsandt @samsinsane