Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(callFirestore): prevent coercing 0 values (#1039) #1058

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

prescottprue
Copy link
Owner

@prescottprue prescottprue commented Aug 29, 2023

Description

Original PR here by @michaeldawson: #1039

Created this PR to iron our lint issues and handling of null in an object. Updated tests to include confirming of 0 value

Screenshots (if appropriate)

@prescottprue prescottprue changed the title fix(callFirestore): prevent coercing 0 values (#1039) - @michaeldawson fix(callFirestore): prevent coercing 0 values (#1039) Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #1058 (3beee61) into main (53ee14f) will decrease coverage by 0.09%.
Report is 261 commits behind head on main.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
- Coverage   87.27%   87.19%   -0.09%     
==========================================
  Files           6        6              
  Lines         283      289       +6     
  Branches      102      108       +6     
==========================================
+ Hits          247      252       +5     
- Misses         10       11       +1     
  Partials       26       26              
Files Changed Coverage Δ
src/firebase-utils.ts 83.96% <55.55%> (-0.80%) ⬇️
src/attachCustomCommands.ts 88.15% <100.00%> (ø)
src/extendWithFirebaseConfig.ts 100.00% <100.00%> (ø)
src/plugin.ts 100.00% <100.00%> (ø)
src/tasks.ts 86.90% <100.00%> (+0.65%) ⬆️

@prescottprue prescottprue merged commit 68db8c1 into main Aug 29, 2023
@prescottprue prescottprue deleted the firestore-0-coerce branch August 29, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants