Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enforce type imports #1370

Merged
merged 10 commits into from
Oct 11, 2024
Merged

fix: enforce type imports #1370

merged 10 commits into from
Oct 11, 2024

Conversation

prescottprue
Copy link
Owner

Description

  • Enforce type imports
  • Replace eslint with biom

Screenshots (if appropriate)

Copy link

github-actions bot commented Oct 11, 2024

size-limit report 📦

Path Size
CommonJS: attachCustomCommands 8.19 KB (-0.02% 🔽)
CommonJS: plugin 8.18 KB (-0.03% 🔽)

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.26%. Comparing base (b0d9e07) to head (3211e11).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/firebase-utils.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1370   +/-   ##
=======================================
  Coverage   74.26%   74.26%           
=======================================
  Files           6        6           
  Lines         579      579           
  Branches      212      212           
=======================================
  Hits          430      430           
  Misses        131      131           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prescottprue prescottprue merged commit 72b3377 into main Oct 11, 2024
6 checks passed
@prescottprue prescottprue deleted the biome branch October 11, 2024 22:01
Copy link

🎉 This PR is included in version 4.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant