feat: drop support prefixed env vars + default service account file #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## beta #759 +/- ##
==========================================
- Coverage 87.34% 87.27% -0.07%
==========================================
Files 7 6 -1
Lines 316 283 -33
Branches 112 102 -10
==========================================
- Hits 276 247 -29
Misses 10 10
+ Partials 30 26 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
🎉 This PR is included in version 3.0.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
prescottprue
added a commit
that referenced
this pull request
Dec 31, 2022
* feat: update node build version to 16 (#746) * feat: remove all file system interaction directly in cypress-firebase * chore: update badge in readme BREAKING CHANGE: Drop support for Node versions below 16 Build for Node 16 (previously Node 12) Drop support for environment variables auto-prefixed by CI env (such as `STAGE_SERVICE_ACCOUNT`) (#759) Drop support for loading default service account file at ./serviceAccount.json - `GOOGLE_APPLICATION_CREDENTIALS` env variable should be used instead [as described in Firebase docs](https://firebase.google.com/docs/admin/setup#initialize-sdk)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
./serviceAccount.json-GOOGLE_APPLICATION_CREDENTIALSenv variable should be used instead. This removes all file system interaction directly within cypress-firebaseScreenshots (if appropriate)