-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dataReducer doesn't merge previous data on LISTENER_RESPONSE action. #294
Comments
Thanks for reporting. Feel free to make a PR if you get a chance. Otherwise, I'll get to it when I can |
I think #218 means that the example given under Query Options for " Maybe we could use something like |
I have created a PR to revert the changes and add merged data back |
We might have to be careful here - merging logic was removed in the past since it caused an issue with params being removed from documents (from another client or server) after data has already been loaded on the current client. Maybe I'm misunderstanding, but just want to make sure we handle this case before moving forward since that test that was changed is in place for a reason |
Hey @prescottprue |
What is the current behavior?
dataReducer doesn't merge previous data on LISTENER_RESPONSE action.
What is the expected behavior?
dataReducer should merge previous data on LISTENER_RESPONSE action when previous data is exist and meta does not have subcollections
Which version of redux-firestore are you using? What about other dependencies?
0.13.0
This commit(bab3aa5) breaks the action.
If intended, the above conditional code(
redux-firestore/src/reducers/dataReducer.js
Line 53 in d7a5613
The text was updated successfully, but these errors were encountered: