Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should no error when exe NERDTreeFind for file in a linked directory #884

Closed
SolaWing opened this issue Sep 10, 2018 · 1 comment · Fixed by #896
Closed

should no error when exe NERDTreeFind for file in a linked directory #884

SolaWing opened this issue Sep 10, 2018 · 1 comment · Fixed by #896

Comments

@SolaWing
Copy link

Environment

  • Operating System: MAC
  • Vim version :version: nvim v0.3.1
  • NERDTree version git rev-parse --short HEAD: newest: 808f5b2

Process

  1. Given a file /tmp/A/a.txt, and a link /tmp/B -> /tmp/A
  2. enter vim, and exe: :edit /tmp/B/a.txt
  3. then exe: :NERDTreeFind

Current Result

Throw Exception:

处理 function <SNR>9_lod_cmd[3]..<SNR>110_findAndRevealPath[40]..161 时发生错误:
第    4 行:
E605: 异常没有被捕获: NERDTree.InvalidArgumentsError: /tmp/B/a.txt should be under /private/tmp/A

Expected Result

No Exception

Screenshot(s)

Possible Fix

@SolaWing SolaWing changed the title shouldn't throw error when exe NERDTreeFind for file in a linked directory should no error when exe NERDTreeFind for file in a linked directory Sep 10, 2018
@PhilRunninger
Copy link
Member

I can reproduce this error without the linked folder B. I get the same message with :edit /tmp/A/a.txt and :NERDTreeFind. It must be happening because /tmp/ is a link that points to /private/tmp.

Note to self: Look for the resolve() function invocations. I'm guessing it needs to be done on the filename /tmp/A/a.txt before looking for it under /private/tmp/A.

@PhilRunninger PhilRunninger added the PR Under Review Coding is finished, and a pull request has been created and is being reviewed. label Oct 11, 2018
@PhilRunninger PhilRunninger removed the PR Under Review Coding is finished, and a pull request has been created and is being reviewed. label Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants