Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidance to implement clickhouse connector #12440

Closed
zeeshanabid94 opened this issue Mar 7, 2019 · 8 comments
Closed

Guidance to implement clickhouse connector #12440

zeeshanabid94 opened this issue Mar 7, 2019 · 8 comments

Comments

@zeeshanabid94
Copy link

Hey guys!

We were recently looking at looker as our BI tool but as it turns out presto does not support clickhouse. Clickhouse has JDBC drivers and Presto has a extendable interface to support any JDBC driver.

I have gone through the presto developer docs. I would appreciate it if there were other sources of guidance that any one knows.

Thank you!

@ebyhr
Copy link
Contributor

ebyhr commented Mar 8, 2019

Hi, you can develop JDBC based connector very easily. presto-mysql or presto-postgresql in presto(this) repository would help you.
Example PR to implement JDBC based connector:

Ref: #9620

@spaghettifunk
Copy link

I opened a PR aiming to solve this problem. Happy to get feedback and help on this.

@zeeshanabid94
Copy link
Author

Hey! I already made a connector for clickhouse. Would you like to review my plugin, give feedback and eventually merge that into this repo?

@spaghettifunk
Copy link

spaghettifunk commented Mar 10, 2019

@zeeshanabid94 of course! send me the link and i'll check it out! My team and I need to have Clickhouse working with Presto ASAP :)

@zeeshanabid94
Copy link
Author

Great! I'll send you the link to the repo tomorrow.

@highker
Copy link
Contributor

highker commented Mar 11, 2019

@spaghettifunk , @zeeshanabid94 could you discuss which PR you wanna proceed with? We can review once you have reached a consensus.

@highker
Copy link
Contributor

highker commented Mar 11, 2019

Let's use #9620 to track the ticket.

@highker highker closed this as completed Mar 11, 2019
@huynhphuong10284
Copy link

Great! I'll send you the link to the repo tomorrow.

Please share for this friend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants