Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Druid connector fails to identify tables with uppercase names. #15587

Closed
aniruddhasanyal opened this issue Jan 6, 2021 · 7 comments · Fixed by #15920
Closed

Druid connector fails to identify tables with uppercase names. #15587

aniruddhasanyal opened this issue Jan 6, 2021 · 7 comments · Fixed by #15920

Comments

@aniruddhasanyal
Copy link

When trying to query druid tables with uppercase names, the query fails with the error: Table 'TABLE_NAME' does not exist. A similar issue was observed in MySql connector and the attribute option "case-insensitive-name-matching" was added for MySql connector catalogue file. I have tried using the same attribute for Druid catalogue and it doesn't seem to be working.

@rschlussel
Copy link
Contributor

@zhenxiao @beinan can you help?

@beinan
Copy link
Member

beinan commented Jan 13, 2021

We don't have case-insensitive-name-matching implemented in druid connection I think.

Just did some research on the behavior of druid and mysql.

According to Druid-SQL's doc https://druid.apache.org/docs/latest/querying/sql.html

All identifiers are case-sensitive and no implicit case conversions are performed.

For mysql, as described in https://dev.mysql.com/doc/refman/8.0/en/identifier-case-sensitivity.html

names are not case-sensitive in Windows, but are case-sensitive in most varieties of Unix.
Mysql also has a system variable which can make mysql to compare by lower case for the table names

We can also check the discussion here #2863

I think the case insensitive matching should be something nice to have.

Looks like we might need something like #13087 for druid connector, I might make it once I got a chance.

@owinbin
Copy link

owinbin commented Jan 26, 2021

we have the same problem too, and the way we solved it like #13087 for druid connector

@beinan
Copy link
Member

beinan commented Jan 28, 2021

we have the same problem too, and the way we solved it like #13087 for druid connector

Really appreciate if you could send a PR for the change on druid connector.

@imjalpreet
Copy link
Member

@beinan in case no one is working on this change, I can work on it for solving this in druid connector.

@beinan
Copy link
Member

beinan commented Feb 3, 2021

@imjalpreet feel free to send a PR to us, I can help review. many thanks!

@imjalpreet
Copy link
Member

@beinan I got caught up in some other work due to which this got delayed. Late last week I have raised a PR for this, can you help review the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants