Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate existing functions to adapt Runtime Metric unit #17777

Closed
zacw7 opened this issue May 17, 2022 · 0 comments · Fixed by #17784
Closed

Migrate existing functions to adapt Runtime Metric unit #17777

zacw7 opened this issue May 17, 2022 · 0 comments · Fixed by #17784
Assignees

Comments

@zacw7
Copy link
Member

zacw7 commented May 17, 2022

As unit is introduced to runtime metrics - #17633, functions like the following one needs to adopt the new signature with unit.

    public void incrementCounter(String name, long value)
    {
        if (verboseRuntimeStatsEnabled) {
            stats.addMetricValue(name, value);
        }
    }
@zacw7 zacw7 changed the title Migrate existing functions to adopt Runtime Metric unit Migrate existing functions to adapt Runtime Metric unit May 19, 2022
@erick576 erick576 self-assigned this May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants