-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prettier-plugin-svelte doesn't work with eslint-plugin-prettier #472
Closed
chumager opened this issue
Jun 22, 2022
· 1 comment
· Fixed by #483, #484 or #553 · May be fixed by chohannah/wanted_pre_onboarding#19 or chohannah/wanted_pre_onboarding#20
Closed
prettier-plugin-svelte doesn't work with eslint-plugin-prettier #472
chumager opened this issue
Jun 22, 2022
· 1 comment
· Fixed by #483, #484 or #553 · May be fixed by chohannah/wanted_pre_onboarding#19 or chohannah/wanted_pre_onboarding#20
Comments
It should be easy to fix this by adding eslint-plugin-prettier/eslint-plugin-prettier.js Lines 215 to 225 in 551dd0e
Would you like to raise a PR? |
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this issue
Jul 4, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) | devDependencies | minor | [`4.1.0` -> `4.2.1`](https://renovatebot.com/diffs/npm/eslint-plugin-prettier/4.1.0/4.2.1) | --- ### Release Notes <details> <summary>prettier/eslint-plugin-prettier</summary> ### [`v4.2.1`](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#​421) [Compare Source](prettier/eslint-plugin-prettier@v4.2.0...v4.2.1) ##### Patch Changes - [#​485](prettier/eslint-plugin-prettier#485) [`5736ed5`](prettier/eslint-plugin-prettier@5736ed5) Thanks [@​JounQin](https://github.com/JounQin)! - chore: reuse prettierRcOptions instead of resolveConfig again ### [`v4.2.0`](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#​420) [Compare Source](prettier/eslint-plugin-prettier@v4.1.0...v4.2.0) ##### Minor Changes - [#​483](prettier/eslint-plugin-prettier#483) [`7bd70b6`](prettier/eslint-plugin-prettier@7bd70b6) Thanks [@​JounQin](https://github.com/JounQin)! - feat: support svelte out of box close [#​472](prettier/eslint-plugin-prettier#472), close [#​482](prettier/eslint-plugin-prettier#482) We recommend to use [`eslint-plugin-svelte`](https://github.com/ota-meshi/eslint-plugin-svelte) instead of [`eslint-plugin-svelte3`](https://github.com/sveltejs/eslint-plugin-svelte3). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [x] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1442 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
5 tasks
This was referenced Sep 11, 2024
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of
eslint
are you using?v8.17.0
What version of
prettier
are you using?2.7.1
What version of
eslint-plugin-prettier
are you using?4.0.0
Please paste any applicable config files that you're using (e.g.
.prettierrc
or.eslintrc
files)What source code are you linting?
What did you expect to happen?
I want to be able to format svelte files just like prettier do.
What actually happened?
I'm trying to add a plugin to prettier to allow svelte files to be linted and formated but, I get this output:
If I use prettier alone, it formats the file correctly, using the same configuration as in the .eslintrc
I don't know if my configuration is wrong or if the eslint-plugin-prettier can't load other plugins.
Regards.
The text was updated successfully, but these errors were encountered: