-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clarification notice about Flow/React support to the readme #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I just have a minor comment about list formatting.
@@ -84,6 +84,21 @@ This does three things: | |||
|
|||
You can then set Prettier's own options inside a `.prettierrc` file. | |||
|
|||
3. In order to support special ESLint plugins (e.g. [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react)), add extra exclusions for the plugins you use like so: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the numbering here is a bit confusing because there is a separate numbered list directly above this line. Can you change the list above this one to use bullet points (by prefixing each line with *
rather than numbers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I’ve changed it.
Thanks! |
289: Update dependency eslint-plugin-prettier to v2.6.2 r=rehandalal a=renovate[bot] This Pull Request updates dependency [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) from `v2.6.1` to `v2.6.2` <details> <summary>Release Notes</summary> ### [`v2.6.2`](https://github.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md#v262-2018-07-06) [Compare Source](prettier/eslint-plugin-prettier@v2.6.1...v2.6.2) * Fix: Add representation for \r to showInvisibles ([#​100](`https://github.com/prettier/eslint-plugin-prettier/issues/100`)) ([731bbb5](prettier/eslint-plugin-prettier@731bbb5)) * Docs: Add clarification about Flow/React support to readme ([#​96](`https://github.com/prettier/eslint-plugin-prettier/issues/96`)) ([977aa77](prettier/eslint-plugin-prettier@977aa77)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <bot@renovateapp.com>
Resolves #95