Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use node: import prefix #381

Merged
merged 1 commit into from
May 2, 2023
Merged

Use node: import prefix #381

merged 1 commit into from
May 2, 2023

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 self-assigned this May 25, 2022
@Shinigami92
Copy link
Member Author

Hey @antfu, I tried something out here: using an extra CI forced to NodeJS v14.6

This version of pnpm requires at least Node.js v14.19

It looks like as we are using pnpm (same as in Vite) we are forced to at least that version 🤔
So should we bump the engine in Vite? (ref vitejs/vite#8309)

image

@Shinigami92
Copy link
Member Author

I can use fileURLToPath(new URL('./src', import.meta.url)) in vite.config.ts when switching to prettier v3

@Shinigami92 Shinigami92 force-pushed the use-node-import-prefix branch 2 times, most recently from cbf9d2f to 85f6b47 Compare May 2, 2023 14:43
@Shinigami92 Shinigami92 marked this pull request as ready for review May 2, 2023 14:45
@Shinigami92 Shinigami92 merged commit d12212a into main May 2, 2023
@Shinigami92 Shinigami92 deleted the use-node-import-prefix branch May 2, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Shinigami92 Shinigami92

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Shinigami92