Trailing comma missing

[ledermann]

After upgrading from 2.1.0 to 3.1.1, the trailingComma option seems to be ignored.

Metadata

• Operating system: MacOS 12.3.1
• Ruby version: 3.1.2
• Node version: 18.0.0
• @prettier/plugin-ruby version: 3.1.1
• syntax_tree version: 2.4.1

Prettier config

{
  "trailingComma": "all",
  "singleQuote": true,
  "rubyPlugins": "plugin/single_quotes",
  "printWidth": 80,
  "tabWidth": 2
}

Input

def foo(value)
  [
    Rails.configuration.x.foo.beginning_of_month,
    value.beginning_of_month
  ].max
end

Current output

def foo(value)
  [
    Rails.configuration.x.foo.beginning_of_month,
    value.beginning_of_month # comma missing
  ].max
end

Expected output

def foo(value)
  [
    Rails.configuration.x.foo.beginning_of_month,
    value.beginning_of_month,  # this one!
  ].max
end

[boris-petrov]

Unfortunately there doesn't seem to be a plugin for syntax-tree for a trailing comma... which is unfortunate. 😄 I'll also keep back using v2 until this is resolved.

[kddnewton]

I will hopefully get to this eventually. If anyone is looking to help out, this would be a great one.

[kddnewton]

Going to close this for now since I'm tracking it over on syntax tree.

[timkrins]

Just came across this issue when upgrading.

Changed our .prettierrc file to include

  "rubyPlugins": "plugin/single_quotes,plugin/trailing_comma",

and now works.
(syntax_tree 2.7.1)