Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension host terminated vscode 1.40.0 #1050

Closed
MareikeTaeubner opened this issue Nov 13, 2019 · 3 comments
Closed

Extension host terminated vscode 1.40.0 #1050

MareikeTaeubner opened this issue Nov 13, 2019 · 3 comments
Labels
locked Please open a new issue and fill out the template instead of commenting.

Comments

@MareikeTaeubner
Copy link

MareikeTaeubner commented Nov 13, 2019

Summary

VSCode extension host crashes on startup if prettier code formatter extension is enabled (disabling vscode core functions like git integration).

Github Repository to Reproduce Issue

Link to a Github repo that can be used to reproduce the issue.

Steps To Reproduce:

  1. Disable all vscode extensions.
  2. open vscode window -> it should open without issue
  3. enable prettier code formatter extension -> the extension host crashes
  4. open the vscode window anew -> the extension host crashes
  5. disable prettier extension again and restart extension host -> restart successful

Expected result

The VSCode window opens without error.

Actual result

VSCode extension host crashes - disabling not just prettier but core functions (because vscode handles that badly :( ).

Additional information

Since VSCode does not log which extension crashed I am not 100% sure prettier is at fault here, but with only prettier activated it is an educated guess.

Error message after Startup:
extensionHostWindow

Console error messages:
prettierCrash

VS Code Version:
Version: 1.40.0 (user setup)
Commit: 86405ea23e3937316009fc27c9361deee66ffbf5
Datum: 2019-11-06T17:02:13.381Z
Electron: 6.1.2
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
Betriebssystem: Windows_NT x64 10.0.18362

Prettier & Prettier Plugin Version:
Plugin: 3.3.5
Prettier: 1.19.1 (but crashes also without prettier locally installed)

OS and version: Windows 10 Pro 10.0.18362 Build 18362

@MareikeTaeubner
Copy link
Author

It does seem to be a problem with vscode itself (microsoft/vscode#84803). Sorry for mistakenly reporting here :(

@ntotten
Copy link
Member

ntotten commented Nov 18, 2019

No problem. Thanks for following up!

@ntotten ntotten closed this as completed Nov 18, 2019
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the locked Please open a new issue and fill out the template instead of commenting. label Apr 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

No branches or pull requests

2 participants