Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong zIndex for p-toast #10801

Closed
nlachancedev opened this issue Nov 2, 2021 · 1 comment
Closed

Wrong zIndex for p-toast #10801

nlachancedev opened this issue Nov 2, 2021 · 1 comment
Assignees
@yigitfindikli
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
13.0.0-rc.1

Comments

@nlachancedev
Copy link

nlachancedev commented Nov 2, 2021 •
edited
Loading

Like this other issue #10767 who is fixed in #10762, it seems like "p-toast" has been forgotten too. When I'm in a modal dialog, all toast messages are hidden behind dialog overlay.

My guess is that you got some code in toast.ts that uses DomHandler instead of ZIndexUtils (https://github.com/primefaces/primeng/blob/master/src/app/components/toast/toast.ts#L301).
@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 8, 2021
@yigitfindikli yigitfindikli added this to the 13.0.0-rc.2 milestone Nov 8, 2021
@yigitfindikli yigitfindikli self-assigned this Nov 8, 2021
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Nov 9, 2021
@yigitfindikli yigitfindikli modified the milestones: 13.0.0-rc.2, 13.0.0-rc.1 Nov 9, 2021
@yigitfindikli
Copy link
Contributor

Hi @nlachancedev,

Thanks for your investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yigitfindikli yigitfindikli

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
13.0.0-rc.1
Development

No branches or pull requests
2 participants
@yigitfindikli @nlachancedev