Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverlayPanel | Close icon overflows in small screen (flipped) #11796

Closed
alejandra-moreno-espinar opened this issue Aug 8, 2022 · 2 comments
Closed
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@alejandra-moreno-espinar

Describe the bug

When the overlapanel flips the space is not calculated properly and the close button is cut off.

Environment

6da08cf1-cdd6-4b2c-8cf6-026d014a1d77

Reproducer

No response

Angular version

13.0.2

PrimeNG version

13.3.1

Build / Runtime

Angular CLI App

Language

ALL

Node version (for AoT issues node --version)

16.13.0

Browser(s)

Chrome 103.0.5060.66, Firefox 97.0.2

Steps to reproduce the behavior

Open an overlaypanel with not enough space below so that it flips. Adjust the view port until the overlaypanel window fits in the space above the target but not the close icon.

Expected behavior

The close button should be taken into account when calculating the space the overlay needs.

@alejandra-moreno-espinar alejandra-moreno-espinar added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Aug 8, 2022
@alejandra-moreno-espinar
Copy link
Author

It's very easy to reproduce it using the PrimeNG overlaypanel example: https://stackblitz.com/edit/primeng-overlaypanel-demo.
Shrink the browser in height and the button icon will be cut off.
610_511_1

@cetincakiroglu cetincakiroglu self-assigned this Aug 9, 2022
@cetincakiroglu cetincakiroglu added this to the 14.0.1 milestone Aug 9, 2022
@cetincakiroglu cetincakiroglu changed the title OverlayPanel: when flipped, the close button is cut off OverlayPanel | Close icon overflows in small screen (flipped) Aug 9, 2022
@alejandra-moreno-espinar
Copy link
Author

Great, many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants