Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Angular 15 support #12243

Closed
PeterHewat opened this issue Nov 17, 2022 · 7 comments · Fixed by #12271
Closed

Add Angular 15 support #12243

PeterHewat opened this issue Nov 17, 2022 · 7 comments · Fixed by #12271
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@PeterHewat
Copy link

Describe the bug

PrimeNG 14.2.2 is restricted to Angular < 15
Unable to update to Angular 15

Environment

Standard Angular / PrimeNG application.

Reproducer

No response

Angular version

15.0.0

PrimeNG version

14.2.2

Build / Runtime

Angular CLI App

Language

ALL

Node version (for AoT issues node --version)

18.12.1

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@PeterHewat PeterHewat added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 17, 2022
@kyjus25
Copy link
Contributor

kyjus25 commented Nov 17, 2022

Don't mind me just watchin 👀

@AndrewAKovalenko
Copy link
Contributor

Also it would be great to migrate components and directives to standalone versions to be able to use Directive Composition API and etc.

@slyk
Copy link

slyk commented Nov 19, 2022

Like and subscribe it :) wait it

@ghost
Copy link

ghost commented Nov 21, 2022

What are the plans about standalone components?
Will be a big refactoring needed with XxxModule, e.g. MessagesModule?
Or will e.g. MessagesModule have the same name, but be converted to a standalone component under the hood instead?

@kyjus25
Copy link
Contributor

kyjus25 commented Nov 21, 2022

@j-s-fesfwd Given how opinionated Angular is, I would be very surprised to see them using the XxxModule naming convention if it is not truly a module.

Since standalone components are interop-able with normal ones, I'd speculate they will unblock people from being able to use v15 first before worrying about making them standalone which would come in a release at a later date.

They could either introduce a breaking change and force every component to standalone, or they could include both module and standalone options (which seems like a pain to tree-shake and would probably require import changes).

I guess we will see what the community does. If it becomes customary in the library community to provide both options, I reckon they will follow suit.

However, I'm just speculating and would love to hear from a PrimeNG dev. Angular 15 is the hot topic right now, I'm sure they've got it covered. With such an integral library like PrimeNG is I'd imagine they will get an update out relatively quickly.

@cetincakiroglu cetincakiroglu linked a pull request Nov 22, 2022 that will close this issue
@cetincakiroglu cetincakiroglu added this to the 15.0.0-rc.1 milestone Nov 22, 2022
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 22, 2022
@cetincakiroglu cetincakiroglu self-assigned this Nov 22, 2022
@kyjus25
Copy link
Contributor

kyjus25 commented Nov 22, 2022

🙌 🙌 🙌 YES

Thank you @cetincakiroglu 🫡. You are the hero this world needed

@cetincakiroglu
Copy link
Contributor

🙌 🙌 🙌 YES

Thank you @cetincakiroglu 🫡. You are the hero this world needed

Happy to help, you're welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants