Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: formArray marked Touched when item gets removed #12956

Closed
davidediak opened this issue Apr 26, 2023 · 0 comments · Fixed by #12958
Closed

Calendar: formArray marked Touched when item gets removed #12956

davidediak opened this issue Apr 26, 2023 · 0 comments · Fixed by #12958
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.3.0

Comments

@davidediak
Copy link
Contributor

davidediak commented Apr 26, 2023 •
edited
Loading

Describe the bug

when you have a calendar attached to a control that is containted in a formArray, and that formArray's item get's removed after view init, the formArray will be wrongly marked as touched.

this happens because of this change

PR

Environment

just see the stackblitz

Reproducer

https://stackblitz.com/edit/github-o6rbby?file=src/app/app.component.ts

Angular version

15.2.8

PrimeNG version

15.4.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

10

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@davidediak davidediak added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 26, 2023
@davidediak davidediak mentioned this issue Apr 26, 2023
Merged
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 21, 2023
@mertsincan mertsincan added this to the 16.2.1 milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.3.0
Development

Successfully merging a pull request may close this issue.

fix: formarray wrongly marked as touched davidediak/primeng
3 participants
@mertsincan @davidediak @gucal