Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfirmDialog: Duplicated AcceptIcons #13001

Closed
gpolcode opened this issue May 5, 2023 · 1 comment
Closed

ConfirmDialog: Duplicated AcceptIcons #13001

gpolcode opened this issue May 5, 2023 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@gpolcode
Copy link

gpolcode commented May 5, 2023

Describe the bug

When using the ConfirmDialog with an AcceptIcon, it will show twice within the button:
image

The bug maybe got introduced when the templates for the button got added:

[icon]="option('acceptIcon')"

Then the templates adds another icon:

<i *ngIf="option('acceptIcon')" [class]="option('acceptIcon')"></i>

Environment

The bug occurs on primeng version 15.4.1 but not on 15.3.0

Reproducer

https://stackblitz.com/edit/hvvmec?file=src/app/demo/confirm-dialog-position-demo.ts

Angular version

15.2.1

PrimeNG version

15.4.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.14.2

Browser(s)

No response

Steps to reproduce the behavior

  1. Open stackblitz
  2. Click the button "Click me"
  3. Check the icons on the accept button

Expected behavior

The icon should only show once

@gpolcode gpolcode added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 5, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 5, 2023
@cetincakiroglu cetincakiroglu added this to the 16.0.0-rc.1 milestone May 5, 2023
@cetincakiroglu cetincakiroglu self-assigned this May 5, 2023
@gpolcode
Copy link
Author

@cetincakiroglu This issue was added to the v16 milestone, but the bug also appears on the version 15.x.x.
Will this get released for version 15.x.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants