Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileUpload | Drag and drop highlight enhancement #13306

Closed
ajjp opened this issue Jul 8, 2023 · 5 comments
Closed

FileUpload | Drag and drop highlight enhancement #13306

ajjp opened this issue Jul 8, 2023 · 5 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@ajjp
Copy link

ajjp commented Jul 8, 2023

Describe the bug

p-fileupload-highlight css class not defined in _fileupload.scss

Environment

Windows

Reproducer

No response

Angular version

16.1.3

PrimeNG version

16.0.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.1

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@ajjp ajjp added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 8, 2023
@ajjp ajjp changed the title Component: FileUpload Component: FileUpload p-fileupload-highlight css class not defined in _fileupload.scss Jul 9, 2023
@SoyDiego
Copy link
Contributor

I don't understand your issue.
Can be more specific or write more information, screenshots, etc...?

Thanks

@ajjp
Copy link
Author

ajjp commented Jul 12, 2023

p-fileupload

When you drag the files over the drop area the class p-fileupload-highlight is applied but there isn't one defined in the _fileupload.scss file.

Thanks

@SoyDiego
Copy link
Contributor

SoyDiego commented Jul 12, 2023

p-fileupload

When you drag the files over the drop area the class p-fileupload-highlight is applied but there isn't one defined in the _fileupload.scss file.

Thanks

Thanks for your reply @ajjp. You are right, I have checked the problem.
I have created a PR solving the problem and you can check here: #13326
If the PrimeNG Team approve, maybe for the next version will be there.

EDIT

I have close the PR and I have created a new one in the correct project: primefaces/primeng-sass-theme#24

@ajjp
Copy link
Author

ajjp commented Jul 13, 2023

I've checked it and it works like a charm. Thank you!

@SoyDiego
Copy link
Contributor

I've checked it and it works like a charm. Thank you!

Happy to help! 🚀

@cetincakiroglu cetincakiroglu added this to the 16.4.0 milestone Sep 26, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 26, 2023
@cetincakiroglu cetincakiroglu self-assigned this Sep 26, 2023
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Sep 26, 2023
@cetincakiroglu cetincakiroglu changed the title Component: FileUpload p-fileupload-highlight css class not defined in _fileupload.scss FileUpload | Drag and drop highlight enhancement Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants