Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-chips: [addOnTab] feature has no effect. Tab key should make a chip and keep focus in the text box. #14706

Closed
Da13Harris opened this issue Feb 3, 2024 · 0 comments · Fixed by #14726
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Da13Harris
Copy link

Describe the bug

In the <p-chips> element, there is an @input() property called addOnTab. This property does nothing when the tab key is pressed, and is not referenced anywhere in the PrimeNG chips.ts code.

Environment

Windows 10

Reproducer

https://stackblitz.com/edit/github-mxeong?file=src%2Fapp%2Fapp.component.html

Angular version

17.1.1

PrimeNG version

17.5.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.1

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to the StackBlitz provided.
  2. In the first field, type a new value like "test" and press tab.
  3. In the second field, type a new value like "test" and press tab.
  4. Nothing happens in either case.

Expected behavior

When addOnTab="true", pressing the tab key should create a new chip with the entered value and keep the focus within the text field for the next chip to be created, just like how the enter key works.

This behavior works perfectly in PrimeNG 16.0.2.

@Da13Harris Da13Harris added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 3, 2024
@Da13Harris Da13Harris changed the title p-chips: [addOnTab] feature has no effect. It used to keep focus within the text box. p-chips: [addOnTab] feature has no effect. Tab should make a chip to keep focus within the text box. Feb 3, 2024
@Da13Harris Da13Harris changed the title p-chips: [addOnTab] feature has no effect. Tab should make a chip to keep focus within the text box. p-chips: [addOnTab] feature has no effect. Tab key should make a chip to keep focus within the text box. Feb 3, 2024
@Da13Harris Da13Harris changed the title p-chips: [addOnTab] feature has no effect. Tab key should make a chip to keep focus within the text box. p-chips: [addOnTab] feature has no effect. Tab key should make a chip and keep focus in the text box. Feb 3, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 5, 2024
@cetincakiroglu cetincakiroglu added this to the 17.7.0 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants