Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabMenu: In Aura theme, active tab underline does not update properly when using routes with asynchronous resolvers #15269

Closed
c-o-l-i-n opened this issue Apr 15, 2024 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@c-o-l-i-n
Copy link
Contributor

Describe the bug

In the new Aura theme, when using a TabMenu to navigate between routes that use asynchronous resolver functions, the "active-tab underline" does not update properly. It works fine in the Lara theme.

Here is the same Stackblitz app, 1 with Aura and 1 with Lara. The app uses a "dummy" resolver that delays the loading of each route by 1 second.

PrimeNG Aura theme TabMenu doesn't transition properly with route resolvers
aura

PrimeNG Lara theme TabMenu works fine with route resolvers
lara

Environment

Stackblitz

Reproducer

https://stackblitz.com/edit/stackblitz-starters-aktdll?file=src%2Fmain.ts

Angular version

17.2.0

PrimeNG version

17.13.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Create Angular routes with asynchronous resolver functions
  2. Create a TabMenu with tabs that link to these routes
  3. Click on the tabs to navigate

Expected behavior

The "active-tab underline" should move to the active tab after the route resolves.

@c-o-l-i-n c-o-l-i-n added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 15, 2024
@cetincakiroglu cetincakiroglu added this to the 17.14.0 milestone Apr 17, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 18, 2024
@cetincakiroglu cetincakiroglu self-assigned this Apr 18, 2024
@c-o-l-i-n
Copy link
Contributor Author

Thanks, @cetincakiroglu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants