Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong hover color in outline button (New theming) #16463

Closed
d-eder opened this issue Oct 1, 2024 · 2 comments
Closed

Wrong hover color in outline button (New theming) #16463

d-eder opened this issue Oct 1, 2024 · 2 comments
Assignees
Labels
Resolution: Wontfix Issue will not be fixed due to technical limitations

Comments

@d-eder
Copy link

d-eder commented Oct 1, 2024

Describe the bug

We are setting the hoverColor property in the button component style:

    button: {
      colorScheme: {
        light: {
          outlined: {
            primary: {
              ...
              hoverColor: '{content.white}'
            }
          } ...

In the screenshot you can see, that the variable --p-button-outlined-primary-color is used for the color.
Since the element is hovered, the variable --p-button-outlined-primary-hover-color should be used instead.

image

Environment

  • Local environment using ng serve
  • Customized theming (with Lara Theme as default preset)

Reproducer

No response

Angular version

18.2.5

PrimeNG version

18.0.0-beta.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.17.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Override the button styles for the inline button
  2. Set the property hoverColor to a different color
  3. Hover the button in the browser -> the wrong text color is used

Expected behavior

The correct hover color should be used (as mentioned above, the css variable --p-button-outlined-primary-hover-color should be used with the css hover selector

@d-eder d-eder added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 1, 2024
@cetincakiroglu cetincakiroglu added this to the 18.0.0-rc.1 milestone Oct 26, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 19, 2024
@mertsincan mertsincan removed this from PrimeNG v18 Nov 20, 2024
@cagataycivici
Copy link
Member

I don't see a hoverColor in the outlined button tokens, outlined buttons and regular buttons are different, outlined button removes background so should not use text colors from the regular colors. I don't understand the issue. So this token does not exist;

button.outlined.primary.hover.color

button: {
      colorScheme: {
        light: {
          outlined: {
            primary: {
              ...
              hoverColor: '{content.white}'
            }
          } ...

@cagataycivici cagataycivici removed this from the 18.0.0-rc.2 milestone Nov 26, 2024
@cagataycivici cagataycivici added Resolution: Wontfix Issue will not be fixed due to technical limitations and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Nov 26, 2024
Copy link

Unfortunately, this issue cannot be fixed due to technical limitations. PrimeNg team has decided not to pursue a fix, as addressing it would introduce other complications. Thanks a lot for your understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Wontfix Issue will not be fixed due to technical limitations
Projects
Status: Done
Development

No branches or pull requests

4 participants