Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v18 p-columnFilter: Column filtering indicator is missing #16576

Open
rosenthalj opened this issue Oct 17, 2024 · 2 comments · May be fixed by #16588
Open

v18 p-columnFilter: Column filtering indicator is missing #16576

rosenthalj opened this issue Oct 17, 2024 · 2 comments · May be fixed by #16588
Assignees
@cagataycivici @mertsincan
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone
18.x

Comments

@rosenthalj
Copy link
Contributor

Describe the bug

In PrimeNG v18 when a table column is filtered using the p-columnFilter component there is no indication of filtering in the corresponding table column header.

Note: When viewing the screenshots listed below and the videos listed below, you may want to use "full screen mode", because the "highlighting" of the background colors of the v17 filter icons buttons can be hard to see.

The following screenshot compares the "correct" v17 filter table demo after filtering vs "incorrect" v18 filter table demo after filtering:

Angular_Table_Component_and_Angular_Table_Component_and_Angular_Select_Component

The following screenshot compares the style of the filtered name button element for v17 and v18

Angular_Table_Component_and_Angular_Table_Component_and_History_for_src_app_components_megamenu_megamenu_ts_-_primefaces_primeng_and_Angular_Select_Component

The following video shows the v17 Table Advanced Filter demo "indicating" that column filters are set

v17TableColumnFilterWorking.mov

The following video shows the v18 Table Advanced Filter demo "not indicating" that column filters are set

v18TableColumnFilterBug.mov

Environment

n/a

Reproducer

https://v18.primeng.org/table#filter-advanced

Angular version

18.x

PrimeNG version

18.0.0.beta-3

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

n/a

Browser(s)

chrome, firefox, safari

Steps to reproduce the behavior

  1. Run the v18 Table Filter Advance Demo: https://v18.primeng.org/table#filter-advanced
  2. Filter for one or more columns
    --- After the table is filtered there will be no indications in the table that any of the filters have been set (bad)

Expected behavior

When a column filter is set the corresponding column filter has a visual indication that it has been set.

I.e. v18 column filter set indicating functionality should work similarly to the current v17 functionality
@rosenthalj rosenthalj added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 17, 2024
EnricoMessall added a commit to Arematics/primeng that referenced this issue Oct 18, 2024
@EnricoMessall
fix: primefaces#16576
108ade2 
 + CX Function add support for flatting functions for styleClass (Similar to ngStyle doing it)
 + Added new theming for p-column filter active button color
 + Added p-datatable-column-filter-button-active class again
@EnricoMessall EnricoMessall linked a pull request Oct 18, 2024 that will close this issue
Open
EnricoMessall added a commit to Arematics/primeng that referenced this issue Oct 18, 2024
@EnricoMessall
fix: primefaces#16576
b74e1df 
 + Undo changes to cx function
 + Used custom styleClass transformer on styleClass inputs instead to provide safe translation always
@cetincakiroglu cetincakiroglu added this to the 18.0.0-rc.1 milestone Oct 26, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 18, 2024
@mertsincan mertsincan linked a pull request Nov 18, 2024 that will close this issue
Fixed primefaces#16576 - Column Filter missing primary color #16588
Open
@mertsincan mertsincan removed this from PrimeNG v18 Nov 20, 2024
@cagataycivici
Copy link
Member

It seems to be missing yes but we can't add a new token right now due to RC stage, it'll be fixed in v18.1.0. Also an issue in PrimeVue which should be fixed in v4.3.0.

@cagataycivici cagataycivici modified the milestones: 18.0.0-rc.2, 18.x Nov 22, 2024
@mertsincan mertsincan removed this from PrimeNG v18 Nov 25, 2024
@shaman-apprentice
Copy link
Contributor

It seems to be missing yes but we can't add a new token right now due to RC stage, it'll be fixed in v18.1.0. Also an issue in PrimeVue which should be fixed in v4.3.0.

From my point of view, there is nothing to be said against adding a new feature (token) with a reasonable default to a RC. Shouldn't break anything, so why not? Of course, it is your call to make 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

@mertsincan mertsincan

Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Milestone
18.x
Development

Successfully merging a pull request may close this issue.

Fixed primefaces#16576 - Column Filter missing primary color Arematics/primeng
5 participants
@cagataycivici @shaman-apprentice @mertsincan @rosenthalj @cetincakiroglu