Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v18-rc.1 Drawer: visible change DOM of menubar #16801

Open
lengauermario opened this issue Nov 21, 2024 · 0 comments
Open

v18-rc.1 Drawer: visible change DOM of menubar #16801

lengauermario opened this issue Nov 21, 2024 · 0 comments
Assignees
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone

Comments

@lengauermario
Copy link

Describe the bug

I have a layout with the p-menubar and some action drawers in it. When visible is set to true, all content of the menubar is removed.

Menubar:

<p-menubar>
  <ng-template pTemplate="start">
    <h3> Title</h3>
  </ng-template>
  <ng-template pTemplate="end">
    <div class="flex items-center gap-2">
      <notification-drawer></notification-drawer>
      <help-drawer></help-drawer>
      <account-preview></account-preview>
    </div>
  </ng-template>
</p-menubar>

notification-drawer.component

<p-button [rounded]="true" [text]="true" (click)="visible = true" severity="info">
  <ng-template pTemplate="icon">
    <span class="material-icons-outlined">notifications</span>
  </ng-template>
</p-button>

<p-drawer [(visible)]="visible" position="right">
  <ng-template pTemplate="header">
    <div class="flex items-center gap-2">
      <span class="material-icons-outlined">notifications</span>
      <span class="font-bold">Mitteilungen</span>
    </div>
  </ng-template>
  <ng-template pTemplate="content">
    Keine neuen Mitteilungen
  </ng-template>
</p-drawer>

Environment

I noticed this when upgrading from PrimeNG 18.0.0-beta.3 to 18.0.0-rc.1

Reproducer

No response

Angular version

18.2.0

PrimeNG version

18.0.0-rc.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

22.5.1

Browser(s)

Chrome 131.0.6778.71

Steps to reproduce the behavior

  1. click on Icon Button in Menubar
  2. Menubar Content is removed, and no drawer is opend

Expected behavior

Menubar content should not changed.
Drawer should be shown on visible change.

@lengauermario lengauermario added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 21, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 21, 2024
@mertsincan mertsincan added this to the 18.0.0-rc.2 milestone Nov 21, 2024
@mehmetcetin01140 mehmetcetin01140 moved this from Review to Discussion in PrimeNG v18 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: Discussion
Development

No branches or pull requests

3 participants