Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TieredMenu initial hover is broken #9458

Closed
Thorski opened this issue Oct 26, 2020 · 0 comments
Closed

TieredMenu initial hover is broken #9458

Thorski opened this issue Oct 26, 2020 · 0 comments
Assignees
Labels
LTS-FIXED-9.2.0 Fixed in PrimeNG LTS 9.2.0 LTS-FIXED-10.0.5 Fixed in PrimeNG LTS 10.0.5 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Thorski
Copy link

Thorski commented Oct 26, 2020

I'm submitting a ... (check one with "x")
[X] bug report => Search github for a similar issue or PR before submitting

Plunkr Case (Bug Reports)
Please demonstrate your case at stackblitz by using the issue template below. Issues without a test case have much less possibility to be reviewd in detail and assisted.

Can be seen at the showcase (using 10.0.3):
https://www.primefaces.org/primeng/showcase/#/tieredmenu

And correct behavior shown on stackblitz just clicking the stackblitz tab on the above showcase page.
https://stackblitz.com/edit/primeng-tieredmenu-demo

Steps:

  1. Click 'Show' to popup the menu
  2. Hover over 'File'
  3. Observe the next level does/does not pop up.

In 10.0.2 and before, it does pop up.
In 10.0.3 it does NOT pop up. Unless you click once and then henceforth all hovering works.

The problem is in the onItemMouseEnter which used to check the popup but now will never set the activeItem if it is root.

In 10.0.2 it checked this.tieredMenu.popup in onItemMouseEnter and I think that check should be in 10.0.3 as follows:

    if (this.root) {
        if (this.tieredMenu.popup || this.activeItem) {
            this.activeItem = item;
        }
    }

Current behavior
See above example

Expected behavior
Hover should be consistent and not require a click the first time.

Minimal reproduction of the problem with instructions
See above example.

Please tell us about your environment:
Showcase and showcase stackblitz demo

  • PrimeNG version: 10.0.2

  • Browser:
    all

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    typescript

@cagataycivici cagataycivici changed the title TieredMenu initial hover is broken with 10.0.3 TieredMenu initial hover is broken Nov 17, 2020
@cagataycivici cagataycivici self-assigned this Nov 17, 2020
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Nov 17, 2020
@cagataycivici cagataycivici added this to the 11.0.0-rc.1 milestone Nov 17, 2020
@yigitfindikli yigitfindikli added LTS-FIXED-10.0.5 Fixed in PrimeNG LTS 10.0.5 LTS-FIXED-9.2.0 Fixed in PrimeNG LTS 9.2.0 and removed LTS-PORTABLE labels Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-FIXED-9.2.0 Fixed in PrimeNG LTS 9.2.0 LTS-FIXED-10.0.5 Fixed in PrimeNG LTS 10.0.5 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants