Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing a p-columnFilter / p-dropdown using "showClear" X-button throws a TypeError #9578

Closed
austindeboer opened this issue Nov 25, 2020 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@austindeboer
Copy link

[X ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35


**Current behavior**
Clearing a p-columnFilter (that's paired with a p-dropdown for selecting an option) using the `[showClear]="true"` button creates a `ERROR TypeError: Cannot read property 'classList' of null at Function.hasClass, at ColumnFilter.isOutsideClicked, at primeng-table.js:4999....` etc etc etc.

**Expected behavior**
Clearing a p-columnFilter isomg the `showClear` X button clears the value, but should not throw an error since this is expected.

**Please tell us about your environment:**
Windows 10, Visual Studio 2019, NPM, HTTP server

* **Angular version:** 
11.0.2

* **PrimeNG version:**
^9.1.3

* **Browser:**
All

* **Language:**
Typescript
@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 26, 2020
@yigitfindikli yigitfindikli self-assigned this Nov 26, 2020
@yigitfindikli yigitfindikli added this to the 11.0.0-rc.2 milestone Nov 26, 2020
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Nov 26, 2020
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants