Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented fix for #9660 prevents finding a value for simple array of options #9742

Closed
Spaction opened this issue Jan 10, 2021 · 0 comments
Closed
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Spaction
Copy link
Contributor

I'm submitting a ... (check one with "x")

[x ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

https://stackblitz.com/edit/primeng-dropdown-demo-pte6kg?file=src%2Fapp%2Fapp.component.html

Current behavior
When binding an array of simple objects (string[], int[]), the internal value does not get set because of trying to get option.value which does not exist. This is caused by the recent change of looking if OptionLabel is defined and defaulting to option.value instead of option which is how it previously worked.

Expected behavior
Binding an array of simple elements should set the binding of ngModel or correctly update the value of the dropdown

What is the motivation / use case for changing the behavior?
Keep existing functionality for simple cases

  • Angular version:
    11.0

  • PrimeNG version:
    11.1.0-rc.1

  • Browser:
    all

@yigitfindikli yigitfindikli added this to the 11.2.0 milestone Jan 12, 2021
@yigitfindikli yigitfindikli added Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Pending Review Issue or pull request is being reviewed by Core Team labels Jan 12, 2021
@yigitfindikli yigitfindikli modified the milestones: 11.2.0, 11.3.0 Jan 21, 2021
@yigitfindikli yigitfindikli modified the milestones: 11.3.0-Final, 11.3.1, 11.3.2 Mar 9, 2021
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Pending Review Issue or pull request is being reviewed by Core Team labels Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants